-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
gh-135751: traceback: add recent_first and show_lines parameter #135752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
methane
wants to merge
14
commits into
python:main
Choose a base branch
from
methane:traceback-show_lines
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
634f3be
add show_lines
methane a0b4b70
add test
methane 979423f
add recent_first parameter to traceback functions
methane 6038d11
add test for recent_first
methane ded22f3
add doc
methane b7454fb
add whatsnew entry
methane 2efd9fb
add whats'new entry and news entry
methane fc0bf9b
fix doc
methane 878ea1d
Apply suggestions from code review
methane 78dcf35
remove unrelated change
methane abaa598
Apply suggestions from code review
methane 6bb5450
Apply suggestions from code review
methane 8d38237
fix doc
methane 63113e7
Merge branch 'main' into traceback-show_lines
methane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
add show_lines
- Loading branch information
commit 634f3bec894878e4c22b77566118101ae3560e85
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not add the new args via
**kwargs
as was done forcolorize
? It would save having to update all the signatures.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think colorize is in kwargs because of its hidden parameter. Callars determine use COLOR automatically by isatty() and env variables and pass it to here. colorize is not documented.
On the other hand, show_lines and recent_first are explicit parameter.
User need to determine and specify them manually.