8000 gh-135748: use argument clinic for more socket methods by kumaraditya303 · Pull Request #135749 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-135748: use argument clinic for more socket methods #135749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

gh-135748: use argument clinic for more socket methods #135749

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9032ac
optimize perf critical socket functions with AC
kumaraditya303 Jun 20, 2025
53c6f8b
fix comments
kumaraditya303 Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix comments
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Jun 20, 2025
commit 53c6f8bb9b02fe6f28abf8c62b7ee6dff27a3915
4 changes: 2 additions & 2 deletions Modules/clinic/socketmodule.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 2 additions & 5 deletions Modules/socketmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4626,7 +4626,6 @@ _socket_socket_send_impl(PySocketSockObject *s, Py_buffer *pbuf, int flags)
}


/* s.sendall(data [,flags]) method */
/*[clinic input]
_socket.socket.sendall
self as s: self(type="PySocketSockObject *")
Expand All @@ -4638,13 +4637,13 @@ Send a data string to the socket.

For the optional flags argument, see the Unix manual.
This calls send() repeatedly until all data is sent.
If an error occurs, it's impossible to tell how much data has been sent."
If an error occurs, it's impossible to tell how much data has been sent.
[clinic start generated code]*/

static PyObject *
_socket_socket_sendall_impl(PySocketSockObject *s, Py_buffer *pbuf,
int flags)
/*[clinic end generated code: output=ec92861424d3faa8 input=47fb8b126a4f16b3]*/
/*[clinic end generated code: output=ec92861424d3faa8 input=732b15b9ca64dce6]*/

{
char *buf;
Expand Down Expand Up @@ -4876,8 +4875,6 @@ sock_sendmsg_impl(PySocketSockObject *s, void *data)
return (ctx->result >= 0);
}

/* s.sendmsg(buffers[, ancdata[, flags[, address]]]) method */

/*[clinic input]
_socket.socket.sendmsg
self as s: self(type="PySocketSockObject *")
Expand Down
Loading
0