8000 bpo-37047: Refactor AsyncMock setup logic for autospeccing by tirkarthi · Pull Request #13574 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-37047: Refactor AsyncMock setup logic for autospeccing #13574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 27, 2019
Merged

bpo-37047: Refactor AsyncMock setup logic for autospeccing #13574

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e1ae653
Refactor create_autospec and async mock setup logic.
tirkarthi May 25, 2019
5157982
Add new async method implementation to docs
tirkarthi May 25, 2019
f5742d7
Rename async_func_1 to async_func_args
tirkarthi May 25, 2019
0edc644
Move patch with autospec to respective group
tirkarthi May 25, 2019
f4508e8
Rephrase assert_not_awaited like assert_not_called
tirkarthi May 25, 2019
9cd0344
Remove unused variable
tirkarthi May 25, 2019
1b2ca22
Fix grammar to use and
tirkarthi May 25, 2019
e1dd0ef
Use _is_async_func
tirkarthi May 25, 2019
8e6500c
Add NEWS
tirkarthi May 25, 2019
260bb94
Rename the variable that is also loop variable and move function out …
tirkarthi May 26, 2019
6ad528d
Use markup for NEWS
tirkarthi May 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
< 8000 svg style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" aria-hidden="true" data-view-component="true" class="flex-1 anim-rotate"> Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add NEWS
  • Loading branch information
@tirkarthi
tirkarthi committed May 25, 2019
commit 8e6500c6ad3114107faa0cfdb89733b81ec77c75
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2019-05-26-01-20-06.bpo-37047.K9epi8.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Handle late binding and attribute access in AsyncMock setup for
autospeccing. Document newly implemented async methods in MagicMock.
Copy link
Contributor
@mariocj89 mariocj89 May 27, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: If you want to make this a link you can convert the AsyncMock and MagicMock to
:class:unittest.mock.AsyncMock and :class:unittest.mock.MagicMock

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks.

0