8000 gh-129958: New syntax error in format spec applies to both f-strings and t-strings by dylwil3 · Pull Request #135570 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-129958: New syntax error in format spec applies to both f-strings and t-strings #135570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 26, 2025
Merged

gh-129958: New syntax error in format spec applies to both f-strings and t-strings #135570

merged 5 commits into from
Jun 26, 2025

Conversation

dylwil3
Copy link
Contributor
@dylwil3 dylwil3 commented Jun 16, 2025 •
edited
Loading

Closes #129958
(again)

And I think requires backport to 3.14.

Let me know if this warrants a test in test_tstring.py and/or a blurb!

@python-cla-bot
Copy link
python-cla-bot bot commented Jun 16, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link
bedevere-app bot commented Jun 16, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Jun 16, 2025
Closed
@ZeroIntensity ZeroIntensity added the needs backport to 3.14 bugs and security fixes label Jun 16, 2025
tomasr8
tomasr8 reviewed Jun 21, 2025
View reviewed changes
Copy link
Member
@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if this warrants a test in test_tstring.py and/or a blurb!

I think it warrants both :)

@bedevere-app
Copy link
bedevere-app bot commented Jun 24, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@dylwil3 dylwil3 force-pushed the fix-issue-129958 branch from a323c91 to 824e1ca Compare June 24, 2025 11:50
lysnikolaou
lysnikolaou reviewed Jun 25, 2025
View reviewed changes
Copy link
Member
@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor formatting nit and it's good to go!

@dylwil3 @lysnikolaou
nit
68f8f1f 
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
lysnikolaou
lysnikolaou approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member
@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dylwil3!

@lysnikolaou lysnikolaou merged commit fb9e292 into python:main Jun 26, 2025
75 of 77 checks passed
@miss-islington-app
Copy link

Thanks @dylwil3 for the PR, and @lysnikolaou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2025
@dylwil3 @tomasr8
@lysnikolaou @miss-islington
pythongh-129958: New syntax error in format spec applies to both f-st…
f20ed2f 
…rings and t-strings (pythonGH-135570)

(cherry picked from commit fb9e292)

Co-authored-by: Dylan <dylwil3@gmail.com>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Jun 26, 2025

GH-135982 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 26, 2025
@dylwil3 dylwil3 deleted the fix-issue-129958 branch June 26, 2025 14:36
lysnikolaou added a commit that referenced this pull request Jun 26, 2025
@miss-islington @dylwil3
@tomasr8 @lysnikolaou
[3.14] gh-129958: New syntax error in format spec applies to both f-s…
2045453 
…trings and t-strings (GH-135570) (#135982)

(cherry picked from commit fb9e292)

Co-authored-by: Dylan <dylwil3@gmail.com>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasr8 tomasr8 tomasr8 left review comments

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vague behavior when single quoted f-string format_spec contains line break
4 participants
@dylwil3 @tomasr8 @lysnikolaou @ZeroIntensity
0