8000 gh-116738: Make grp module thread-safe by yoney · Pull Request #135434 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-116738: Make grp module thread-safe #135434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-116738: Make grp module thread-safe #135434

wants to merge 4 commits into from

Conversation

yoney
Copy link
Contributor
@yoney yoney commented Jun 12, 2025 •
edited
Loading

Make grp module methods getgrgid() and getgrnam() thread-safe when the GIL is disabled and getgrgid_r()/getgrnam_r() C APIs are not available.

  • Move run_concurrently() to test.support.threading_helper to resuse across multiple tests.

cc: @mpage @colesbury @Yhg1s

@bedevere-app bedevere-app bot mentioned this pull request Jun 12, 2025
Open
@yoney yoney marked this pull request as ready for review June 12, 2025 16:01
@yoney yoney requested a review from rhettinger as a code owner June 12, 2025 16:01
@yoney
Copy link
Contributor Author
yoney commented Jun 12, 2025

Note: I am not sure if there is a CI setup where getgrgid_r()/getgrnam_r() are not available. I tested those manually on my local machine.

@colesbury colesbury requested review from mpage, colesbury and Yhg1s June 16, 2025 17:15
colesbury
colesbury reviewed Jun 16, 2025
View reviewed changes
@colesbury colesbury added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 16, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 269b454 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135434%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 16, 2025
@colesbury colesbury added the needs backport to 3.14 bugs and security fixes label Jun 16, 2025
ZeroIntensity
ZeroIntensity reviewed Jun 16, 2025
View reviewed changes
@rhettinger rhettinger removed their request for review June 17, 2025 02:52
@mpage
Copy link
Contributor
mpage commented Jun 26, 2025

@yoney - Can you merge main and fix up the conflicts?

@yoney
Copy link
Contributor Author
yoney commented Jun 26, 2025

@yoney - Can you merge main and fix up the conflicts?

I rebased and force push but I think this is not the right way, I should have merged the main on top of my branch, I am sorry.

@mpage
Copy link
Contributor
mpage commented Jun 26, 2025

I rebased and force push but I think this is not the right way, I should have merged the main on top of my branch, I am sorry.

No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury left review comments

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

@mpage mpage Awaiting requested review from mpage

@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Assignees
No one assigned
Labels
awaiting review needs backport to 3.14 bugs and security fixes topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yoney @bedevere-bot @mpage @colesbury @ZeroIntensity
0