8000 gh-135335: flush stdout/stderr in forkserver after preloading modules by duaneg · Pull Request #135338 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-135335: flush stdout/stderr in forkserver after preloading modules #135338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 18, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Attempt to fix MacOS test failures
...or at least produce more useful output if they fail
  • Loading branch information
duaneg committed Jun 10, 2025
commit 552266f6a43117954cb0a67071a8ed61839c13d8
5 changes: 4 additions & 1 deletion Lib/test/_test_multiprocessing.py
Original file line number Diff line number Diff line change
Expand Up @@ -6818,9 +6818,12 @@ def test_std_streams_flushed_after_preload(self):
print('stderr', file=sys.stderr)''')

name = os.path.join(os.path.dirname(__file__), 'mp_preload_flush.py')
env = {'PYTHONPATH': ":".join(sys.path)}
env = {'PYTHONPATH': self._temp_dir}
rc, out, err = test.support.script_helper.assert_python_ok(name, **env)
self.assertEqual(rc, 0)

# We want to see all the output if it isn't as expected
self.maxDiff = None
self.assertEqual(out.decode().rstrip(), 'stdout')
self.assertEqual(err.decode().rstrip(), 'stderr')

Expand Down
5 changes: 5 additions & 0 deletions Lib/test/mp_preload_flush.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import multiprocessing
import sys

if __name__ == '__main__':
assert 'a' not in sys.modules
multiprocessing.set_forkserver_preload(['a'])
for _ in range(2):
p = multiprocessing.Process()
p.start()
p.join()
else:
assert 'a' in sys.modules
Loading
0