8000 [3.14] GH-135171: Fix generator expressions one last time (hopefully) by markshannon · Pull Request #135225 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.14] GH-135171: Fix generator expressions one last time (hopefully) #135225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 9, 2025
Merged

[3.14] GH-135171: Fix generator expressions one last time (hopefully) #135225

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c011b5b
Add NULL check to FOR_ITER
markshannon Jun 6, 2025
225e36a
Move GET_ITER back to genexpr creation
markshannon Jun 6, 2025
4bdd75e
Fix up test generators to handle different behavior of gen exprs and …
markshannon Jun 6, 2025
fe8ca4b
Fix up test_dis
markshannon Jun 6, 2025
a96a192
Add news
markshannon Jun 6, 2025
0d47bea
Add back genexpr test
markshannon Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add news
  • Loading branch information
@markshannon
markshannon committed Jun 6, 2025
commit a96a192bd8263b6c159bd26dadbd7a9afb0479f3
6 changes: 6 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2025-06-06-18-57-30.gh-issue-135171.0YtLq6.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Reverts the behavior of generator expressions when created with a
non-iterable to the pre-3.13 behavior of raising a TypeError. It is no
longer possible to cause a crash in the debugger by altering the generator
expression's local variables. This is achieved by moving the ``GET_ITER``
instruction back to the creation of the generator expression and adding an
additional check to ``FOR_ITER``.
0