8000 [3.13] gh-135151: Fix incorrect packaging of pyconfig.h in Windows installer by zooba · Pull Request #135180 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.13] gh- 8000 135151: Fix incorrect packaging of pyconfig.h in Windows installer #135180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

[3.13] gh-135151: Fix incorrect packaging of pyconfig.h in Windows installer #135180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Doc/howto/free-threading-extensions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@ You can use it to enable code that only runs under the free-threaded build::
/* code that only runs in the free-threaded build */
#endif

.. note::

On Windows, this macro is not defined automatically, but must be specified
to the compiler when building. The :func:`sysconfig.get_config_var` function
can be used to determine whether the current running interpreter had the
macro defined.


Module Initialization
=====================

Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Windows/2025-06-05-13-52-36.gh-issue-135151.4PfNZQ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Avoid distributing modified :file:`pyconfig.h` in the traditional installer.
Extension module builds must always specify ``Py_GIL_DISABLED`` when
targeting the free-threaded runtime.
3 changes: 2 additions & 1 deletion Tools/msi/dev/dev_files.wxs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
<Fragment>
<ComponentGroup Id="dev_pyconfig">
<Component Id="include_pyconfig.h" Directory="include" Guid="*">
<File Id="include_pyconfig.h" Name="pyconfig.h" Source="pyconfig.h" KeyPath="yes" />
<!-- gh-135151 Always use the unmodified header for the installer. -->
<File Id="include_pyconfig.h" Name="pyconfig.h" Source="!(bindpath.src)PC\pyconfig.h.in" KeyPath="yes" />
</Component>
</ComponentGroup>
</Fragment>
Expand Down
Loading
0