8000 gh-135069: Fix exception message in encodings.idna module by danielhollas · Pull Request #135071 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-135069: Fix exception message in encodings.idna module #135071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-135069: Fix exception message in encodings.idna module #135071

wants to merge 4 commits into from

Conversation

danielhollas
Copy link
Contributor
@danielhollas danielhollas commented Jun 3, 2025 •
edited by bedevere-app bot
Loading

Fixes #135069.

Requires backport to 3.13 and 3.14 branches.

@danielhollas
Fix exception message in encodings.idna module
fe37cdc 
Fix the 'Unsupported error handling' error message
in the encodings.idna.IncrementalDecoder class.
@danielhollas
Add blurb
78be462
@bedevere-app bedevere-app bot mentioned this pull request Jun 3, 2025
Open
@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 3, 2025
@danielhollas
Copy link
Contributor Author
danielhollas commented Jun 3, 2025 •
edited
Loading

The docs build fails with

cpython/cpython/Doc/build/NEWS:91: WARNING: py:meth reference target not found: encodings.idna.IncrementalDecoder.decode [ref.meth]

The decode method comes from a parent class I believe. Should a link to the private _buffer_decode method instead?

@tomasr8
Copy link
Member
tomasr8 commented Jun 3, 2025

Should a link to the private _buffer_decode method instead?

You could also just link to IncrementalDecoder

@danielhollas
Copy link
Contributor Author
danielhollas commented Jun 3, 2025 •
edited
Loading

You could also just link to IncrementalDecoder

Thanks, makes sense to me. I tried to change it but still got an error:

cpython/Doc/build/NEWS:91: WARNING: py:class reference target not found: encodings.idna.IncrementalDecoder [ref.class]

No matter how long I stare at it the new blurb looks correct to me? Apologies if that is something obvious, I don't have much experience with rst.

EDIT: The windows build failure looks like a transient http error?

@tomasr8
Copy link
Member
tomasr8 commented Jun 4, 2025

Maybe we can suppress the reference with !? Something like

 `:class:`!encodings.idna.IncrementalDecoder

@danielhollas
Copy link
Contributor Author

Maybe we can suppress the reference with !?

That worked, thanks!

tomasr8
tomasr8 approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member
@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! The news entry could be even shorter (and with less detail) but I think this is also fine 🙂

@danielhollas
Copy link
Contributor Author

@tomasr8 @ZeroIntensity congratulations to both on becoming core developers! 👏

I guess this PR could be merged if you re-apply your review now? 😊

ZeroIntensity
ZeroIntensity approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member
@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to hit the green button @tomasr8?

@tomasr8
Copy link
Member
tomasr8 commented Jun 23, 2025

Feel free to press it @ZeroIntensity! 🙂 I'm a bit busy today 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasr8 tomasr8 tomasr8 approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees
No one assigned
Labels
awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

encodings.idna: Unexpanded f-string in "Unsupported error handling" exception
3 participants
@danielhollas @tomasr8 @ZeroIntensity
0