gh-108885: Use subtests for 8000 doctest examples run by unittest #134890
Conversation
Lib/doctest.py
Outdated
| except: | ||
| exception = sys.exc_info() | ||
| exc_info = sys.exc_info() | ||
| exc_info = (*exc_info[:2], exc_info[2].tb_next) |
There was a problem hiding this comment.
We don't need to use sys here:
except BaseException as e:
exc_info = type(e), e, e.__traceback__.tb_next
There was a problem hiding this comment.
Alternatively, save just the exception here and access its parts below where you need them.
There was a problem hiding this comment.
It does not work, because a traceback here is a not a real traceback. You cannot set it as the part of the exception. Fortunately, all traceback formatting functions and TestCase.addSubTest() work with the exc_info triple.
There was a problem hiding this comment.
Well, here it is a real traceback, but in other place we use a mock traceback, so it is easier to use the same pattern here.
There was a problem hiding this comment.
Yeah, I meant that you extract it from the exception object when you need it below (in this function) and pass that to the internal functions that want the triplet. Just get it from the exception and not from sys.exc_info(). It's the same thing.
There was a problem hiding this comment.
This line is actually a part of #134858.
There was a problem hiding this comment.
I applied your suggestion there.
Run each example as a subtest in unit tests synthesized by doctest.DocFileSuite() and doctest.DocTestSuite().
46860db to
55da0a1
Compare
|
Before merging this PR I am going to create and merge a PR for documentation fixes, because the current documentation has some errors. |
Run each example as a subtest in unit tests synthesized by doctest.DocFileSuite() and doctest.DocTestSuite().
📚 Documentation preview 📚: https://cpython-previews--134890.org.readthedocs.build/