-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-134861: Add CSV and 🍌SV output formats to asyncio ps
#134862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
cf70073
75d0b14
4b77995
f5132c9
cd11ad7
21b581a
e44226d
fe3cf6c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,8 @@ | |
from enum import Enum | ||
import sys | ||
from _remote_debugging import RemoteUnwinder, FrameInfo | ||
import csv | ||
|
||
|
||
class NodeType(Enum): | ||
COROUTINE = 1 | ||
|
@@ -232,20 +234,56 @@ def _get_awaited_by_tasks(pid: int) -> list: | |
sys.exit(1) | ||
|
||
|
||
def display_awaited_by_tasks_table(pid: int) -> None: | ||
class TaskTableOutputFormat(Enum): | ||
table = "table" | ||
csv = "csv" | ||
bsv = "bsv" | ||
# As per the words of the asyncio 🍌SV spec lead: | ||
# > 🍌SV is not just a format. It’s a lifestyle. A philosophy. | ||
# https://www.youtube.com/watch?v=RrsVi1P6n0w | ||
|
||
|
||
_header = ('tid', 'task id', 'task name', 'coroutine stack', 'awaiter chain', 'awaiter name', 'awaiter id') | ||
|
||
|
||
def display_awaited_by_tasks_table( | ||
pid: int, | ||
format_: TaskTableOutputFormat | str = TaskTableOutputFormat.table | ||
) -> None: | ||
"""Build and print a table of all pending tasks under `pid`.""" | ||
|
||
tasks = _get_awaited_by_tasks(pid) | ||
table = build_task_table(tasks) | ||
format_ = TaskTableOutputFormat(format_) | ||
if format_ == TaskTableOutputFormat.table: | ||
_display_awaited_by_tasks_table(table) | ||
else: | ||
_display_awaited_by_tasks_csv(table, format_) | ||
|
||
|
||
def _display_awaited_by_tasks_table(table) -> None: | ||
# Print the table in a simple tabular format | ||
print( | ||
f"{'tid':<10} {'task id':<20} {'task name':<20} {'coroutine stack':<50} {'awaiter chain':<50} {'awaiter name':<15} {'awaiter id':<15}" | ||
f"{_header[0]:<10} {_header[1]:<20} {_header[2]:<20} {_header[3]:<50} {_header[4]:<50} {_header[5]:<15} {_header[6]:<15}" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Try storing the numbers in either another array or a tulle with headers and for loop this print. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi John 👋 I don't think it would make the code significantly cleaner, if that was your intent. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Feel free to disagree, but writing header[0] header[1] etc makes it hard to read which property is associated with which length. Thank you for your consideration. |
||
) | ||
print("-" * 180) | ||
for row in table: | ||
print(f"{row[0]:<10} {row[1]:<20} {row[2]:<20} {row[3]:<50} {row[4]:<50} {row[5]:<15} {row[6]:<15}") | ||
|
||
|
||
def _display_awaited_by_tasks_csv(table, format_: TaskTableOutputFormat) -> None: | ||
match format_: | ||
case TaskTableOutputFormat.csv: | ||
delimiter = ',' | ||
case TaskTableOutputFormat.bsv: | ||
delimiter = '\N{BANANA}' | ||
case _: | ||
raise ValueError(f"Unknown output format: {format_}") | ||
csv_writer = csv.writer(sys.stdout, delimiter=delimiter) | ||
csv_writer.writerow(_header) | ||
csv_writer.writerows(table) | ||
|
||
|
||
def display_awaited_by_tasks_tree(pid: int) -> None: | ||
"""Build and print a tree of all pending tasks under `pid`.""" | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Add CSV output format to asyncio ps | ||
|
||
Absolutely no other output format was added in this PR 🍌 |
Uh oh!
There was an error while loading. Please reload this page.