gh-134557: Suppress immortalization in _PyCode_GetScriptXIData under free-threading #134686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @emmatyping for commit 4dac776 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134686%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
|
Oh, the refleak buildbots won't catch any leaks because there aren't any tests that could trigger a leak. My mistake🤦♀️ |
This was referenced May 26, 2025
|
Thanks @neonene for the PR, and @ericsnowcurrently for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 26, 2025
…under free-threading (pythongh-134686) Disable immortalization around Py_CompileString*(). The same approach as 332356b that fixed the refleaks in compile() and eval(). (cherry picked from commit c60f39a) Co-authored-by: neonene <53406459+neonene@users.noreply.github.com> E: 09e72cf can pass test_capi, test_sys and test__interpchannels with this patch for me.
|
GH-134738 is a backport of this pull request to the 3.14 branch. |
|
Thanks for the fix, @neonene! |
ericsnowcurrently
pushed a commit
that referenced
this pull request
May 26, 2025
… under free-threading (gh134738) Disable immortalization around Py_CompileString*(). The same approach as 332356b that fixed the refleaks in compile() and eval(). E: 09e72cf can pass test_capi, test_sys and test__interpchannels with this patch for me. (cherry picked from commit c60f39a, AKA gh-134686) Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same approach as 332356b that fixed the refleaks in
compile()andeval().cc @colesbury @ericsnowcurrently @emmatyping I'm not so confident.
E: 09e72cf can pass
test_capi,test_sysandtest__interpchannelswith this patch for me.