8000 [3.13] gh-134152: Fix UnboundLocalError in email._header_value_parser _get_ptext_to_endchars (GH-134233) by miss-islington · Pull Request #134677 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content
8000

[3.13] gh-134152: Fix UnboundLocalError in email._header_value_parser _get_ptext_to_endchars (GH-134233) #134677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged

[3.13] gh-134152: Fix UnboundLocalError in email._header_value_parser _get_ptext_to_endchars (GH-134233) #134677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/email/_header_value_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,6 +1020,8 @@ def _get_ptext_to_endchars(value, endchars):
a flag that is True iff there were any quoted printables decoded.

"""
if not value:
return '', '', False
fragment, *remainder = _wsp_splitter(value, 1)
vchars = []
escape = False
Expand Down
33 changes: 33 additions & 0 deletions Lib/test/test_email/test__header_value_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,19 @@ def test_get_qp_ctext_non_printables(self):
[errors.NonPrintableDefect], ')')
self.assertEqual(ptext.defects[0].non_printables[0], '\x00')

def test_get_qp_ctext_close_paren_only(self):
self._test_get_x(parser.get_qp_ctext,
')', '', ' ', [], ')')

def test_get_qp_ctext_open_paren_only(self):
self._test_get_x(parser.get_qp_ctext,
'(', '', ' ', [], '(')

def test_get_qp_ctext_no_end_char(self):
self._test_get_x(parser.get_qp_ctext,
'', '', ' ', [], '')


# get_qcontent

def test_get_qcontent_only(self):
Expand Down Expand Up @@ -503,6 +516,14 @@ def test_get_qcontent_non_printables(self):
[errors.NonPrintableDefect], '"')
self.assertEqual(ptext.defects[0].non_printables[0], '\x00')

def test_get_qcontent_empty(self):
self._test_get_x(parser.get_qcontent,
'"', '', '', [], '"')

def test_get_qcontent_no_end_char(self):
self._test_get_x(parser.get_qcontent,
'', '', '', [], '')

# get_atext

def test_get_atex 8000 t_only(self):
Expand Down Expand Up @@ -1283,6 +1304,18 @@ def test_get_dtext_open_bracket_mid_word(self):
self._test_get_x(parser.get_dtext,
'foo[bar', 'foo', 'foo', [], '[bar')

def test_get_dtext_open_bracket_only(self):
self._test_get_x(parser.get_dtext,
'[', '', '', [], '[')

def test_get_dtext_close_bracket_only(self):
self._test_get_x(parser.get_dtext,
']', '', '', [], ']')

def test_get_dtext_empty(self):
self._test_get_x(parser.get_dtext,
'', '', '', [], '')

# get_domain_literal

def test_get_domain_literal_only(self):
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2025-05-19-10-32-11.gh-issue-134152.INJC2j.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fixed :exc:`UnboundLocalError` that could occur during :mod:`email` header
parsing if an expected trailing delimiter is missing in some contexts.
Loading
0