8000 gh-134557: Revert "gh-132775: Use _PyCode GetScriptXIData()" by ericsnowcurrently · Pull Request #134599 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-134557: Revert "gh-132775: Use _PyCode GetScriptXIData()" #134599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ericsnowcurrently
Copy link
Member
@ericsnowcurrently ericsnowcurrently commented May 23, 2025

This reverts commit 09e72cf, AKA gh-134511.

We are reverting due to refleaks on free-threaded builds.

@ericsnowcurrently ericsnowcurrently changed the title gh-132775: Revert "Use _PyCode GetScriptXIData()" gh-134557: Revert "gh-132775: Use _PyCode GetScriptXIData()" May 23, 2025
@ericsnowcurrently
Copy link
Member Author

I have verified this clears up the refleak failures locally. I suspect there is still a leak hiding somewhere though, which I'll track down before unreverting.

@ericsnowcurrently ericsnowcurrently enabled auto-merge (squash) May 23, 2025 19:49
@ericsnowcurrently ericsnowcurrently merged commit 8a793c4 into python:main May 23, 2025
42 checks passed
@ericsnowcurrently ericsnowcurrently deleted the revert-pycode-get-script-xidata branch May 23, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0