8000 GH-131798: Optimize cached class attributes and methods in the JIT by brandtbucher · Pull Request #134403 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-131798: Optimize cached class attributes and methods in the JIT #134403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 22, 2025
Merged

GH-131798: Optimize cached class attributes and methods in the JIT #134403

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
54dedf6
Optimize (and peephole away) cached attributes
brandtbucher May 21, 2025
b7d8c03
blurb add
brandtbucher May 21, 2025
844299c
Add a test for _LOAD_ATTR_METHOD_LAZY_DICT
brandtbucher May 21, 2025
c83acf9
fixup
brandtbucher May 21, 2025
bb5e18e
Add link back
brandtbucher May 21, 2025
0e20c44
fixup
brandtbucher May 21, 2025
d490347
Revert the _LOAD_SMALL_INT stuff.
brandtbucher May 21, 2025
58017a8
Add tests
brandtbucher May 21, 2025
1d2f546
make regen-cases
brandtbucher May 21, 2025
0202451
Catch up with main
brandtbucher May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a test for _LOAD_ATTR_METHOD_LAZY_DICT
  • Loading branch information
@brandtbucher
brandtbucher committed May 21, 2025
commit 844299c74bd7b4be234d59209f5a9a267a4bf9a6
8 changes: 7 additions & 1 deletion Lib/test/test_capi/test_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2166,27 +2166,33 @@ class D:
A = 1
def m(self):
return 1
class E(Exception):
def m(self):
return 1
def f(n):
x = 0
c = C()
d = D()
e = E()
for _ in range(n):
x += C.A # _LOAD_ATTR_CLASS
x += c.A # _LOAD_ATTR_NONDESCRIPTOR_WITH_VALUES
x += d.A # _LOAD_ATTR_NONDESCRIPTOR_NO_DICT
x += c.m() # _LOAD_ATTR_METHOD_WITH_VALUES
x += d.m() # _LOAD_ATTR_METHOD_NO_DICT
x += e.m() # _LOAD_ATTR_METHOD_LAZY_DICT
return x

res, ex = self._run_with_optimizer(f, TIER2_THRESHOLD)
self.assertEqual(res, 5 * TIER2_THRESHOLD)
self.assertEqual(res, 6 * TIER2_THRESHOLD)
self.assertIsNotNone(ex)
uops = get_opnames(ex)
self.assertNotIn("_LOAD_ATTR_CLASS", uops)
self.assertNotIn("_LOAD_ATTR_NONDESCRIPTOR_WITH_VALUES", uops)
self.assertNotIn("_LOAD_ATTR_NONDESCRIPTOR_NO_DICT", uops)
self.assertNotIn("_LOAD_ATTR_METHOD_WITH_VALUES", uops)
self.assertNotIn("_LOAD_ATTR_METHOD_NO_DICT", uops)
self.assertNotIn("_LOAD_ATTR_METHOD_LAZY_DICT", uops)


def global_identity(x):
Expand Down
0