gh-134210: handle signals in _curses.window.getch
#134326
Open
+35
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried this change with the script: from curses import wrapper
import ctypes
def main(window):
window.nodelay(True)
return window.getch()
print(wrapper(main))Before (without this change), it displays After (with this change), it fails with the exception: So this change is backward incompatible. Is it deliberate? |
|
Hum. No it's not meant to be broken! Only the signals should be handled, but otherwise we shouldn't raise an exception. |
|
Now I am bit conflicted. Ideally, we should return -1 for everything or raise an exception as in the other functions. I don't know why it was historically chosen to return -1 for However, since I don't want to break stuff, I don't know how we can make a smooth transition, except by raising a warning before returning -1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_curses.window.getchdoes not check for interruption signals as_curses.window.{getkey,get_wch}do #134210