8000 gh-62824: Add alias for iso-8859-8-i which is the same as iso-8859-8 by basbloemsaat · Pull Request #134306 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-62824: Add alias for iso-8859-8-i which is the same as iso-8859-8 #134306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2025
Merged

gh-62824: Add alias for iso-8859-8-i which is the same as iso-8859-8 #134306

merged 2 commits into from
May 20, 2025

Conversation

basbloemsaat
Copy link
Contributor
@basbloemsaat basbloemsaat commented May 20, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 20, 2025
Closed
@basbloemsaat basbloemsaat marked this pull request as ready for review May 20, 2025 13:11
@ambv ambv mentioned this pull request May 20, 2025
Closed
@ambv
Copy link
Contributor
ambv commented May 20, 2025

Based on @malemburg's comment on #32279, I'm landing this.

@ambv ambv merged commit 5ab66a8 into python:main May 20, 2025
41 checks passed
@ambv ambv added the needs backport to 3.14 bugs and security fixes label May 20, 2025
@miss-islington-app 8000
Copy link

Thanks @basbloemsaat for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
@basbloemsaat @ringof
@arhadthedev @miss-islington
pythongh-62824: Add alias for iso-8859-8-i which is the same as iso-8…
33793b9 
…859-8 (pythongh-134306)

(cherry picked from commit 5ab66a8)

Co-authored-by: Bas Bloemsaat <bas@bloemsaat.com>
Co-authored-by: David Goncalves <davegoncalves@gmail.com>
Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@bedevere-app
Copy link
bedevere-app bot commented May 20, 2025

GH-134330 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025
ambv pushed a commit that referenced this pull request May 20, 2025
@miss-islington @basbloemsaat
@ringof @arhadthedev
[3.14] gh-62824: Add alias for iso-8859-8-i which is the same as iso-…
2dedf5e 
…8859-8 (gh-134306) (gh-134330)

(cherry picked from commit 5ab66a8)

Co-authored-by: Bas Bloemsaat <bas@bloemsaat.com>
Co-authored-by: David Goncalves <davegoncalves@gmail.com>
Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
hroncok
hroncok reviewed May 27, 2025
View reviewed changes
Lib/test/test_codecs.py
Comment on lines +3111 to +3116
def test_alias_modules_exist(self):
encodings_dir = os.path.dirname(encodings.__file__)
for value in encodings.aliases.aliases.values():
codec_file = os.path.join(encodings_dir, value + ".py")
self.assertTrue(os.path.isfile(codec_file),
"Codec file not found: " + codec_file)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A follow-up for this test: #134777

We see failures when running this in Fedora with installed Python 3.14.0b2.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hroncok hroncok hroncok left review comments

@malemburg malemburg malemburg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@basbloemsaat @ambv @hroncok @malemburg @ringof @arhadthedev
0