Move lock check in dealloc to an assert

python · colesbury · May 23, 2025 · May 19, 2025 · May 19, 2025 · May 20, 2025
commit d8854c53a2ef11b73b96748f34124f5d93ea0d22
diff --git a/Modules/_zstd/compressor.c b/Modules/_zstd/compressor.c
@@ -402,9 +402,7 @@ ZstdCompressor_dealloc(PyObject *ob)
         ZSTD_freeCCtx(self->cctx);
     }
 
-    if (PyMutex_IsLocked(&self->lock)) {
-        PyMutex_Unlock(&self->lock);
-    }
+    assert(!PyMutex_IsLocked(&self->lock));
 
     /* Py_XDECREF the dict after free the compression context */
     Py_CLEAR(self->dict);

diff --git a/Modules/_zstd/decompressor.c b/Modules/_zstd/decompressor.c
@@ -602,9 +602,7 @@ ZstdDecompressor_dealloc(PyObject *ob)
         ZSTD_freeDCtx(self->dctx);
     }
 
-    if (PyMutex_IsLocked(&self->lock)) {
-        PyMutex_Unlock(&self->lock);
-    }
+    assert(!PyMutex_IsLocked(&self->lock));
 
     /* Py_CLEAR the dict after free decompression context */
     Py_CLEAR(self->dict);