-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-134201: Expand Base85 Documentation #134288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-134201: Expand Base85 Documentation #134288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor changes to clarify the text.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks @biniona !
Thanks @biniona for the PR, and @CAM-Gerlach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Thanks @biniona for the PR, and @CAM-Gerlach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
pythonGH-134288) Explain history of de-facto standard and how to pick between the two Base-85 encoding functions in the base-64 module. --------- (cherry picked from commit 66aaad6) Co-authored-by: Alek Binion <aleksander.binion@gmail.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
pythonGH-134288) Explain history of de-facto standard and how to pick between the two Base-85 encoding functions in the base-64 module. --------- (cherry picked from commit 66aaad6) Co-authored-by: Alek Binion <aleksander.binion@gmail.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
GH-134297 is a backport of this pull request to the 3.13 branch. |
GH-134298 is a backport of this pull request to the 3.14 branch. |
…cs (GH-134288) (#134298) gh-134201: Expand explanation of Base85 encodings in base64 docs (GH-134288) Explain history of de-facto standard and how to pick between the two Base-85 encoding functions in the base-64 module. --------- (cherry picked from commit 66aaad6) Co-authored-by: Alek Binion <aleksander.binion@gmail.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
…cs (GH-134288) (#134297) gh-134201: Expand explanation of Base85 encodings in base64 docs (GH-134288) Explain history of de-facto standard and how to pick between the two Base-85 encoding functions in the base-64 module. --------- (cherry picked from commit 66aaad6) Co-authored-by: Alek Binion <aleksander.binion@gmail.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@biniona live in the docs! https://docs.python.org/3/library/base64.html |
Expands Documentation of Base-85 encodings. Explains history of de-facto standard and how to pick between the two Base-85 encoding functions in the
base-64
module.