E52D [2.7] bpo-35121: prefix dot in domain for proper subdomain validation (GH-10258) by tirkarthi · Pull Request #13426 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

[2.7] bpo-35121: prefix dot in domain for proper subdomain validation (GH-10258)#13426

Merged
miss-islington merged 2 commits intopython:2.7from
tirkarthi:backport-bpo35121-2.7
Jun 15, 2019
Merged

[2.7] bpo-35121: prefix dot in domain for proper subdomain validation (GH-10258)#13426
miss-islington merged 2 commits intopython:2.7from
tirkarthi:backport-bpo35121-2.7

Conversation

@tirkarthi
Copy link
Member
@tirkarthi tirkarthi commented May 19, 2019

This is a manual backport of ca7fe50 since 2.7 has http.cookiejar in cookielib

https://bugs.python.org/issue35121

@tirkarthi
Copy link
Member Author

Requesting review from @benjaminp since this is a manual backport of the security fix in 3.x branch

@tirkarthi tirkarthi closed this May 19, 2019
@tirkarthi tirkarthi reopened this May 19, 2019
@tirkarthi
Copy link
Member Author

@serhiy-storchaka @orsenthil @alex Would be helpful to have your review of this security backport to 2.7 branch.

@alex alex changed the title [2.7] bpo-35121: prefix dot in domain for proper subdomain validation [2.7] bpo-35121: prefix dot in domain for proper subdomain validation (GH-10258) Jun 15, 2019
@bedevere-bot bedevere-bot added the type-security A security issue label Jun 15, 2019
alex
alex approved these changes Jun 15, 2019 BF5D
@tirkarthi
Copy link
Member Author

Thank you @alex :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-security A security issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0