8000 gh-125843: fix `test_curses.test_attributes` on x86-64 macOS by picnixz · Pull Request #134252 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-125843: fix test_curses.test_attributes on x86-64 macOS #134252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 20, 2025

Conversation

picnixz
Copy link
Member
@picnixz picnixz commented May 19, 2025

Apparently, on x86-64 MacOS Intel with and without GIL, test_curses.test_attributes failed, but I don't really know why after looking at the code. So, I'll just check by hand to check what kind of error is actually being returned.

@picnixz

This comment was marked as resolved.

@bedevere-bot

This comment was marked as resolved.

@picnixz picnixz changed the title gh-125843: improve traceback when reporting unexpected curses errors gh-125843: fix test_curses.test_attributes on x86-64 macOS May 19, 2025
@picnixz

This comment was marked as resolved.

@bedevere-bot

This comment was marked as resolved.

@picnixz
Copy link
Member Author
picnixz commented May 19, 2025

!buildbot x86-64 MacOS Intel

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 8fcdb53 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134252%2Fmerge

The command will test the builders whose names match following regular expression: x86-64 MacOS Intel

The builders matched are:

  • x86-64 MacOS Intel ASAN NoGIL PR
  • x86-64 MacOS Intel NoGIL PR

@picnixz picnixz added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025
@picnixz picnixz added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025
@python python deleted a comment from bedevere-bot May 19, 2025
@python python deleted a comment from bedevere-bot May 19, 2025
@picnixz picnixz added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 8004b3d 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134252%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025
@picnixz picnixz enabled auto-merge (squash) May 20, 2025 08:26
@picnixz picnixz merged commit e007e62 into python:main May 20, 2025
38 checks passed
@encukou
Copy link
Member
encukou commented May 20, 2025

Thank you for the fix!

@picnixz picnixz deleted the patch/curses-checks-125843 branch May 20, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0