8000 gh-134214: Fix test case in pyrepl by jtemporal · Pull Request #134223 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-134214: Fix test case in pyrepl #134223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

gh-134214: Fix test case in pyrepl #134223

merged 1 commit into from
May 19, 2025

Conversation

jtemporal
Copy link
Contributor
@jtemporal jtemporal commented May 19, 2025 •
edited by bedevere-app bot
Loading

Added extra code to the test to make the test actually test the right way. Thanks for the help @tomasr8

@python-cla-bot
Copy link
python-cla-bot bot commented May 19, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot mentioned this pull request May 19, 2025
Closed
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label May 19, 2025
@bedevere-app
Copy link
bedevere-app bot commented May 19, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@ambv ambv added the needs backport to 3.14 bugs and security fixes label May 19, 2025
@ambv ambv merged commit faebf87 into python:main May 19, 2025
50 checks passed
@miss-islington-app
Copy link

Thanks @jtemporal for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2025
@jtemporal @miss-islington
pythongh-134214: Fix test case in pyrepl (pythongh-134223)
0d79502 
(cherry picked from commit faebf87)

Co-authored-by: Jessica Temporal <jtemporal@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented May 19, 2025

GH-134229 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 19, 2025
ambv pushed a commit that referenced this pull request May 19, 2025
@miss-islington @jtemporal
[3.14] gh-134214: Fix test case in pyrepl (gh-134223) (gh-134229)
7d995ea 
(cherry picked from commit faebf87)

Co-authored-by: Jessica Temporal <jtemporal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasr8 tomasr8 tomasr8 approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtemporal @tomasr8 @ambv
0