gh-134155: fix AttributeError in email._header_value_parser.get_address #134194
Conversation
Misc/NEWS.d/next/Library/2025-05-18-23-46-21.gh-issue-134152.30HwbX.rst
Outdated
Show resolved
Hide resolved
UnboundLocalError while parsing message_id in email
…0HwbX.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
Drat. I somehow missed your PR before I submitted mine (#134233). We should combine the two. You want to pull in the extra tests from mine? Thanks for catching the defect issue. I think my early return is clearer than setting pos=0 even though they have the same effect. |
|
Yeah, your solution with early return looks better than mine. I'm happy to revert my changes with |
…d .get_qcontent" This reverts commit 5c3fa11.
…thub.com:sergey-miryanov/cpython into pythongh-134152-fix-unbound-local-error-in-email
|
Tests should pass after #134233 will be merged. |
|
Sure, that works for me. |
|
@bitdancer I'm sorry to bother you. Perhaps I misunderstood you. Do you expect me to merge your PR with this one? |
|
No, I just haven't gotten around to merging mine yet. I'll do it soon ;) |
|
Thanks! I wasn't sure that I got you right, so I thought I'd clarify. |
|
(Updating from |
UnboundLocalError while parsing message_id in emailUnboundLocalError while parsing message_id in email
UnboundLocalError while parsing message_id in email
Misc/NEWS.d/next/Library/2025-05-18-23-46-21.gh-issue-134152.30HwbX.rst
Outdated
Show resolved
Hide resolved
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks for making the requested changes! @bitdancer: please review the changes made to this pull request. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @bitdancer: please review the changes made to this pull request. |
|
Thanks @sergey-miryanov for the PR, and @bitdancer for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…_address (pythonGH-134194) Append the defect to defects instead of to the parse tree. (cherry picked from commit d9cad074d52fe31327429fd81e4d2eeea3dbe35b) Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-135191 is a backport of this pull request to the 3.14 branch. |
…_address (pythonGH-134194) Append the defect to defects instead of to the parse tree. (cherry picked from commit d9cad07) Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-135192 is a backport of this pull request to the 3.13 branch. |
…t_address (GH-134194) (#135192) gh-134155: fix AttributeError in email._header_value_parser.get_address (GH-134194) Append the defect to defects instead of to the parse tree. (cherry picked from commit d9cad07) Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
…t_address (GH-134194) (#135191) gh-134155: fix AttributeError in email._header_value_parser.get_address (GH-134194) Append the defect to defects instead of to the parse tree. (cherry picked from commit d9cad07) Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
There are two errors:
parse_message_id- I found that in some cases error placed to the list of tokens not of defects.UnboundLocalErrorinemail._header_value_parser.parse_message_id#134152AttributeErrorinemail._header_value_parser.get_address#134155