gh-134036: Improve error messages for invalid raise statements
#134077
+529
−402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysnikolaou
approved these changes
Jun 5, 2025
pablogsal
approved these changes
Jun 6, 2025
|
Great improvement! ❤️ |
|
@pablogsal @sobolevn this commit causes all the latest PR test checks to fail, such as #135002 #131796 and #135198 . It's all because of the 1 test failed: |
|
I think this passed pre-merge CI but failed post-merge because rebasing it is what broke it... We can roll this back or it can be fixed-forward. If this can't be fixed quickly it should be rolled back. (/cc @hugovk.) |
|
I wrote #135204 to update test_syntax, the fix is trivial (update error messages). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better error message wordings are welcome!
raise from ValueError()error message #134036