8000 gh-134069: bump HACL* revision to incoporate `memset_s` by aeiouaeiouaeiouaeiouaeiouaeiou · Pull Request #134027 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-134069: bump HACL* revision to incoporate memset_s #134027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

gh-134069: bump HACL* revision to incoporate memset_s #134027

merged 1 commit into from
May 16, 2025

Conversation

aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor
@aeiouaeiouaeiouaeiouaeiouaeiou aeiouaeiouaeiouaeiouaeiouaeiou commented May 15, 2025 •
edited by bedevere-app bot
Loading

Also, it would also be nice if this commit was cherry-picked to 3.14 branch.

CC @freakboy3742 @msprotz

freakboy3742
freakboy3742 requested changes May 15, 2025
View reviewed changes
Copy link
Contributor
@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tagged this for back port to 3.14; it doesn't need a news file, but because it's going to involve a back port, we do need a ticket so we have a point of coordination for multiple commits making the "same" change. That would also be a good opportunity to give a high level summary of what has changed - from the look of it, it's the Mac constants, plus some code formatting changes - but it would be good to have a high level summary to confirm that (and then update the PR title to start gh-XXX with the ticket number):

There's also something going on with SBOM checks on Windows - from the look of it, you've updated all the hashes for the individual files, but not the hash for the source HACL* tarball that contains the origin of these changes.

@bedevere-app
Copy link
bedevere-app bot commented May 15, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@aeiouaeiouaeiouaeiouaeiouaeiou
GH-134069: Bump the HACL* revision.
b96621f 
This fixes building with legacy/cross-platform macOS SDKs.

Signed-off-by: aeiouaeiouaeiouaeiouaeiouaeiou <aeioudev@outlook.com>
@picnixz picnixz changed the title Bump the HACL* revision. gh-134069: bump the HACL* revision May 15, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 15, 2025
Closed
@picnixz picnixz changed the title gh-134069: bump the HACL* revision gh-134069: bump HACL* revision to incoporate memset_s May 15, 2025
@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-app
Copy link
bedevere-app bot commented May 15, 2025

Thanks for making the requested changes!

@freakboy3742: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from freakboy3742 May 15, 2025 23:06
freakboy3742
freakboy3742 approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor
@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for those changes - that all looks good now! The merge back to 3.14 should happen soon after this PR lands; watch the comments on this PR for updates.

@freakboy3742 freakboy3742 merged commit 1566c34 into python:main May 16, 2025
44 of 47 checks passed
@miss-islington-app
Copy link

Thanks @aeiouaeiouaeiouaeiouaeiouaeiou for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 16, 2025
@aeiouaeiouaeiouaeiouaeiouaeiou @miss-islington
pythongh-134069: bump HACL* revision to incoporate memset_s (python…
d9a34af 
…GH-134027)

Bumps the HACL* revision to include recent revisions that corrects issues
building with legacy/cross-platform macOS SDKs.
(cherry picked from commit 1566c34)

Co-authored-by: aeiouaeiouaeiouaeiouaeiouaeiou <aeioudev@outlook.com>
Signed-off-by: aeiouaeiouaeiouaeiouaeiouaeiou <aeioudev@outlook.com>
@bedevere-app
Copy link
bedevere-app bot commented May 16, 2025

GH-134084 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 16, 2025
freakboy3742 pushed a commit that referenced this pull request May 16, 2025
@miss-islington @aeiouaeiouaeiouaeiouaeiouaeiou
[3.14] gh-134069: bump HACL* revision to incoporate memset_s (GH-13…
7725ba8 
…4027) (#134084)

Bumps the HACL* revision to include recent revisions that corrects issues
building with legacy/cross-platform macOS SDKs.
(cherry picked from commit 1566c34)

Signed-off-by: aeiouaeiouaeiouaeiouaeiouaeiou <aeioudev@outlook.com>
Co-authored-by: aeiouaeiouaeiouaeiouaeiouaeiou <aeioudev@outlook.com>
@aeiouaeiouaeiouaeiouaeiouaeiou aeiouaeiouaeiouaeiouaeiouaeiou deleted the hacl-star-2025-05 branch May 16, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

@sethmlarson sethmlarson Awaiting requested review from sethmlarson sethmlarson is a code owner

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

@picnixz picnixz Awaiting requested review from picnixz picnixz is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeiouaeiouaeiouaeiouaeiouaeiou @freakboy3742
0