8000 gh-71253: Match _io exception in _pyio by cmaloney · Pull Request #133985 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-71253: Match _io exception in _pyio #133985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2025
Merged

gh-71253: Match _io exception in _pyio #133985

merged 4 commits into from
May 21, 2025

Conversation

cmaloney
Copy link
Contributor
@cmaloney cmaloney commented May 13, 2025

Raise ValueError if an opener returns a negative fd in _pyio.open() to match behavior _io, update test to use self.open so behavior is tested in _pyio (gh-133982)

cmaloney added 2 commits May 13, 2025 18:17
Test was only testing _io, expanded to cover _pyio.
cmaloney and others added 2 commits May 15, 2025 09:38
@cmaloney
Copy link
Contributor Author

cc: @warsaw who implemented this for _io / the C implementation

@ambv ambv merged commit 06eaf40 into python:main May 21, 2025
39 checks passed
@ambv ambv added the needs backport to 3.14 bugs and security fixes label May 21, 2025
@miss-islington-app
Copy link

Thanks @cmaloney for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2025
Test was only testing _io, expanded to cover _pyio.
(cherry picked from commit 06eaf40)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented May 21, 2025

GH-134430 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 21, 2025
@ambv ambv added the needs backport to 3.13 bugs and security fixes label May 21, 2025
@miss-islington-app
Copy link

Thanks @cmaloney for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2025
Test was only testing _io, expanded to cover _pyio.
(cherry picked from commit 06eaf40)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented May 21, 2025

GH-134431 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 21, 2025
ambv pushed a commit that referenced this pull request May 21, 2025
Test was only testing _io, expanded to cover _pyio.

(cherry picked from commit 06eaf40)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
ambv pushed a commit that referenced this pull request May 21, 2025
Test was only testing _io, expanded to cover _pyio.

(cherry picked from commit 06eaf40)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@cmaloney cmaloney deleted the io_test_pyio branch May 21, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0