8000 gh-133810: remove `http.server.CGIHTTPRequestHandler` and `--cgi` flag by picnixz · Pull Request #133811 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-133810: remove http.server.CGIHTTPRequestHandler and --cgi flag#133811

Merged
picnixz merged 19 commits intopython:mainfrom
picnixz:cleanup/315/remove-cgi-handler-133810
May 17, 2025
Merged

gh-133810: remove http.server.CGIHTTPRequestHandler and --cgi flag#133811
picnixz merged 19 commits intopython:mainfrom
picnixz:cleanup/315/remove-cgi-handler-133810

Conversation

@picnixz
Copy link
Member
@picnixz picnixz commented May 10, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 10, 2025
Closed
@picnixz
Copy link
Member Author
picnixz commented May 10, 2025

Free-threaded failure is known: #132983 (comment).

@picnixz picnixz mentioned this pull request May 11, 2025
Open
picnixz
picnixz commented May 11, 2025
View reviewed changes
@donbarbos donbarbos mentioned this pull request May 14, 2025
Merged
picnixz
picnixz commented May 16, 2025
View reviewed changes
picnixz
picnixz commented May 16, 2025
View reviewed changes
@picnixz picnixz requested a review from hugovk May 16, 2025 11:01
hugovk
hugovk reviewed May 16, 2025
View reviewed changes
picnixz and others added 5 commits May 16, 2025 16:30
@picnixz @hugovk
Apply suggestions from code review
fb781d9 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@picnixz
Update test_httpservers.py
782c99d
@picnixz
Update test_httpservers.py
62855fd
@picnixz
Update test_httpservers.py
6bed465
@picnixz @hugovk
Update Misc/NEWS.d/next/Library/2025-05-10-11-04-47.gh-issue-133810.0…
d55959c 
…3WhnK.rst

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@picnixz picnixz requested a review from hugovk May 16, 2025 15:28
@hugovk
Copy link 8000
Member
hugovk commented May 16, 2025

Still some suggestions that GitHub is hiding about not bumping the __version__, and some unused imports in Lib/http/server.py.

picnixz and others added 2 commits May 16, 2025 17:31
@picnixz @hugovk
Update Lib/http/server.py
1978d23 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@picnixz
Update server.py
32fb546
hugovk
hugovk approved these changes May 16, 2025
View reviewed changes
Copy link
Member
@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice cleanup! +28 −755

@picnixz
Copy link
Member Author
picnixz commented May 16, 2025

Thanks for the review! Sorry for this long back and forth but I was using GH UI :')

@hugovk
Copy link
Member
hugovk commented May 16, 2025

It's all good! 🚀

< BE9D div class="TimelineItem js-targetable-element" data-team-hovercards-enabled id="event-17695465919">
@picnixz picnixz self-assigned this May 16, 2025
@picnixz picnixz merged commit faac627 into python:main May 17, 2025
43 checks passed
@picnixz picnixz deleted the cleanup/315/remove-cgi-handler-133810 branch May 17, 2025 07:58
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@picnixz @Pranjal095
pythongh-133810: remove http.server.CGIHTTPRequestHandler and `--cg…
450c60b 
…i` flag (python#133811)

The CGI HTTP request handler has been deprecated since Python 3.13.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@picnixz @taegyunkim
pythongh-133810: remove http.server.CGIHTTPRequestHandler and `--cg…
3fcec37 
…i` flag (python#133811)

The CGI HTTP request handler has been deprecated since Python 3.13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Assignees

@picnixz picnixz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz @hugovk
0