8000 [3.13] gh-133439: Fix dot commands with trailing spaces are mistaken for multi-line sqlite statements in the sqlite3 command-line interface (GH-133440) by tanloong · Pull Request #133765 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.13] gh-133439: Fix dot commands with trailing spaces are mistaken for multi-line sqlite statements in the sqlite3 command-line interface (GH-133440) #133765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 13, 2025
Merged

[3.13] gh-133439: Fix dot commands with trailing spaces are mistaken for multi-line sqlite statements in the sqlite3 command-line interface (GH-133440) #133765

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
771f617
gh-133439: Fix dot commands with trailing spaces are mistaken for mul…
tanloong May 9, 2025
62d4719
Fix tests
tanloong May 9, 2025
23e4b3c
Revert "Fix tests"
tanloong May 10, 2025
2cd00c4
Use `assertEndsWith` from `test.support.testcase.ExtraAssertions`
tanloong May 10, 2025
2f74e65
Fix tests: mix in `ExtraAssertions` to `InteractiveSession`
tanloong May 10, 2025
22d2b27
Revert changes unrelated to the original PR
tanloong May 10, 2025
8899925
Remove `ExtraAssertions` from `CommandLineInterface`
tanloong May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
@tanloong
tanloong committed May 9, 2025
commit 62d471923537967dd51c99605bf0a8a69ace8956
8 changes: 4 additions & 4 deletions Lib/test/test_sqlite3/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,14 @@ def test_interact_version(self):
def test_interact_empty_source(self):
out, err = self.run_cli(commands=("", " "))
self.assertIn(self.MEMORY_DB_MSG, err)
self.assertEndsWith(out, self.PS1)
self.assertTrue(out.endswith(self.PS1))
self.assertEqual(out.count(self.PS1), 3)
self.assertEqual(out.count(self.PS2), 0)

def test_interact_dot_commands_unknown(self):
out, err = self.run_cli(commands=(".unknown_command", ))
self.assertIn(self.MEMORY_DB_MSG, err)
self.assertEndsWith(out, self.PS1)
self.assertTrue(out.endswith(self.PS1))
self.assertEqual(out.count(self.PS1), 2)
self.assertEqual(out.count(self.PS2), 0)
self.assertIn("Error", err)
Expand All @@ -128,15 +128,15 @@ def test_interact_dot_commands_unknown(self):
def test_interact_dot_commands_empty(self):
out, err = self.run_cli(commands=("."))
self.assertIn(self.MEMORY_DB_MSG, err)
self.assertEndsWith(out, self.PS1)
self.assertTrue(out.endswith(self.PS1))
self.assertEqual(out.count(self.PS1), 2)
self.assertEqual(out.count(self.PS2), 0)

def test_interact_dot_commands_with_whitespaces(self):
out, err = self.run_cli(commands=(".version ", ". version"))
self.assertIn(self.MEMORY_DB_MSG, err)
self.assertEqual(out.count(sqlite3.sqlite_version + "\n"), 2)
self.assertEndsWith(out, self.PS1)
self.assertTrue(out.endswith(self.PS1))
self.assertEqual(out.count(self.PS1), 3)
self.assertEqual(out.count(self.PS2), 0)

Expand Down
Loading
0