8000 [3.14] GH-132983: Remove subclassing support from zstd types (GH-133694) by miss-islington · Pull Request #133762 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.14] GH-132983: Remove subclassing support from zstd types (GH-133694) #133762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

[3.14] GH-132983: Remove subclassing support from zstd types (GH-133694) #133762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
GH-132983: Remove subclassing support from zstd types (GH-133694) 
For consistency with ``bz2``, ``lzma``, and ``zlib``.
(cherry picked from commit bd7c585)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
  • Loading branch information
@AA-Turner @miss-islington
AA-Turner authored and miss-islington committed May 9, 2025
commit 59a59e24b1e0ff0a4951eb0497c50bf5ff86afe0
2 changes: 1 addition & 1 deletion Modules/_zstd/compressor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,6 +702,6 @@ static PyType_Slot zstdcompressor_slots[] = {
PyType_Spec zstdcompressor_type_spec = {
.name = "_zstd.ZstdCompressor",
.basicsize = sizeof(ZstdCompressor),
.flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE | Py_TPFLAGS_HAVE_GC,
.flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_HAVE_GC,
.slots = zstdcompressor_slots,
};
2 changes: 1 addition & 1 deletion Modules/_zstd/decompressor.c
View file BA29
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,6 +886,6 @@ static PyType_Slot ZstdDecompressor_slots[] = {
PyType_Spec zstddecompressor_type_spec = {
.name = "_zstd.ZstdDecompressor",
.basicsize = sizeof(ZstdDecompressor),
.flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE | Py_TPFLAGS_HAVE_GC,
.flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_HAVE_GC,
.slots = ZstdDecompressor_slots,
};
2 changes: 1 addition & 1 deletion Modules/_zstd/zstddict.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,6 @@ static PyType_Slot zstddict_slots[] = {
PyType_Spec zstddict_type_spec = {
.name = "_zstd.ZstdDict",
.basicsize = sizeof(ZstdDict),
.flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE | Py_TPFLAGS_HAVE_GC,
.flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_HAVE_GC,
.slots = zstddict_slots,
};
Loading
0