8000 gh-133412: remove the brackets of the optional stack_effect by nybblista · Pull Request #133708 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-133412: remove the brackets of the optional stack_effect #133708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

gh-133412: remove the brackets of the optional stack_effect #133708

merged 1 commit into from
May 9, 2025

Conversation

nybblista
Copy link
Contributor
@nybblista nybblista commented May 8, 2025 •
edited by bedevere-app bot
Loading

Remove the brackets of the optional stack_effect.

@nybblista nybblista requested a review from markshannon as a code owner May 8, 2025 19:53
@bedevere-app bedevere-app bot added the docs Documentation in the Doc dir label May 8, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 8, 2025
Closed
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs May 8, 2025
@picnixz picnixz self-assigned this May 9, 2025
@picnixz picnixz merged commit f77dac6 into python:main May 9, 2025
42 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs May 9, 2025
@picnixz picnixz added the needs backport to 3.14 bugs and security fixes label May 9, 2025
@miss-islington-app
Copy link

Thanks @nybblista for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@picnixz picnixz added the needs backport to 3.13 bugs and security fixes label May 9, 2025
@miss-islington-app
Copy link

Thanks @nybblista for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2025
@nybblista @miss-islington
pythongh-133412: amend docs for the inst definition (pythonGH-133708)
e723e48 
The `stack_effect` is incorrectly documented as being allowed to be optional.
(cherry picked from commit f77dac6)

Co-authored-by: Nybblista <170842536+nybblista@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2025
@nybblista @miss-islington
pythongh-133412: amend docs for the inst definition (pythonGH-133708)
981e1ae 
The `stack_effect` is incorrectly documented as being allowed to be optional.
(cherry picked from commit f77dac6)

Co-authored-by: Nybblista <170842536+nybblista@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented May 9, 2025

GH-133729 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 9, 2025
@bedevere-app
Copy link
bedevere-app bot commented May 9, 2025

GH-133730 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 9, 2025
picnixz pushed a commit that referenced this pull request May 9, 2025
@miss-islington @nybblista
[3.14] gh-133412: amend docs for the inst definition (GH-133708) (#…
47d4947 
…133729)

gh-133412: amend docs for the `inst` definition (GH-133708)

The `stack_effect` is incorrectly documented as being allowed to be optional.
(cherry picked from commit f77dac6)

Co-authored-by: Nybblista <170842536+nybblista@users.noreply.github.com>
picnixz pushed a commit that referenced this pull request May 9, 2025
@miss-islington @nybblista
[3.13] gh-133412: amend docs for the inst definition (GH-133708) (#…
4c7a04b 
…133730)

gh-133412: amend docs for the `inst` definition (GH-133708)

The `stack_effect` is incorrectly documented as being allowed to be optional.
(cherry picked from commit f77dac6)

Co-authored-by: Nybblista <170842536+nybblista@users.noreply.github.com>
@nybblista nybblista deleted the doc-stack-effect branch May 9, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@picnixz picnixz

Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nybblista @picnixz
0