8000 gh-133626: Ensure the traditional Windows installed doesn't accidentally pick up site-packages by zooba · Pull Request #133693 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-133626: Ensure the traditional Windows installed doesn't accidentally pick up site-packages #133693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

gh-133626: Ensure the traditional Windows installed doesn't accidentally pick up site-packages #133693

merged 1 commit into from
May 8, 2025

Conversation

zooba
Copy link
Member
@zooba zooba commented May 8, 2025 •
edited by bedevere-app bot
Loading

@zooba zooba requested a review from a team as a code owner May 8, 2025 18:08
@bedevere-app bedevere-app bot mentioned this pull request May 8, 2025
Closed
@zooba zooba added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 8, 2025
@zooba
Copy link
Member Author
zooba commented May 8, 2025

I'm running a test release to check this, since we don't have a way in the CI build to verify the installer (other than the build being successful)

@zooba zooba merged commit 6ce469d into python:main May 8, 2025
47 checks passed
@miss-islington-app
Copy link

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 8, 2025
@zooba @miss-islington
pythongh-133626: Ensure the traditional Windows installer doesn't acc…
d2b038b 
…identally pick up site-packages (pythonGH-133693)

(cherry picked from commit 6ce469d)

Co-authored-by: Steve Dower <steve.dower@python.org>
@miss-islington-app
Copy link

Sorry, @zooba, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6ce469dcba482772bc94c4048e90fa9598897c4a 3.13

@zooba zooba deleted the gh-133626 branch May 8, 2025 19:47
@bedevere-app
Copy link
bedevere-app bot commented May 8, 2025

GH-133705 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 8, 2025
@bedevere-app
Copy link
bedevere-app bot commented May 8, 2025

GH-133707 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 8, 2025
zooba added a commit that referenced this pull request May 8, 2025
@zooba
gh-133626: Ensure the traditional Windows installer doesn't accidenta…
df85816 
…lly pick up site-packages (GH-133693)
zooba added a commit that referenced this pull request May 8, 2025
@miss-islington @zooba
gh-133626: Ensure the traditional Windows installer doesn't accidenta…
add970f 
…lly pick up site-packages (GH-133693)

(cherry picked from commit 6ce469d)

Co-authored-by: Steve Dower <steve.dower@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zooba zooba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zooba
0