8000 GH-81061: Fix refcount issue when returning `None` from a `ctypes.py_object` callback by dgelessus · Pull Request #13364 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-81061: Fix refcount issue when returning None from a ctypes.py_object callback #13364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 9, 2023
Merged

GH-81061: Fix refcount issue when returning None from a ctypes.py_object callback #13364

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
85026c5
bpo-36880: Add failing test, fix to follow shortly
dgelessus May 16, 2019
2a5aeba
bpo-36880: Fix refcount issue with ctypes callbacks returning None
dgelessus May 16, 2019
611f1b6
Merge branch 'main' into fix_ctypes_callback_none_refcount
dgelessus Jan 1, 2023
fb17c68
Apply suggestions from code review
dgelessus Jan 3, 2023
66ea175
Remove manual sys.getrefcount check in favor of regrtest --huntrleaks
dgelessus Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Eryk Sun <eryksun@gmail.com>
  • Loading branch information
@dgelessus @eryksun
dgelessus and eryksun committed Jan 3, 2023
commit fb17c68cd049f718b75fca287a6c058dcd4c04f6
7 changes: 3 additions & 4 deletions Lib/test/test_ctypes/test_refcounts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,15 +99,14 @@ def func(a, b):

@support.refcount_test
def test_callback_py_object_none_return(self):
"""Test that returning ``None`` from a ``py_object`` callback
does not affect ``None``'s refcount (bpo-36880)."""
# bpo-36880: test that returning None from a py_object callback
# does not decrement the refcount of None.

import sys

for FUNCTYPE in (ctypes.CFUNCTYPE, ctypes.PYFUNCTYPE):
with self.subTest(FUNCTYPE=FUNCTYPE):
proto = FUNCTYPE(ctypes.py_object)
@proto
@FUNCTYPE(ctypes.py_object)
def func():
return None

Expand Down
0