8000 gh-133490: Fix syntax highlighting for remote PDB by godlygeek · Pull Request #133494 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-133490: Fix syntax highlighting for remote PDB #133494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 6, 2025
Merged

gh-133490: Fix syntax highlighting for remote PDB #133494

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a85bc9b
Fix another place where _colorize was checking the server's tty inste…
godlygeek May 6, 2025
78f54f8
Add an integration test
godlygeek May 6, 2025
7797904
Add a type annotation
godlygeek May 6, 2025
7053a37
Print stderr if the integration test fails
godlygeek May 6, 2025
0cdf9d3
Print stdout in addition to stderr on failure
godlygeek May 6, 2025
c92ee9d
More debugging...
godlygeek May 6, 2025
c1b4dce
Don't run pdb -p in a child process
godlygeek May 6, 2025
5a5e120
Clean up every fd we open
godlygeek May 6, 2025
89bdd52
Skip the test if attaching fails
godlygeek May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Print stderr if the integration test fails
  • Loading branch information
@godlygeek
godlygeek committed May 6, 2025
commit 7053a371d843a19807853311c15b7f7b4bc8b9bb
15 changes: 13 additions & 2 deletions Lib/test/test_remote_pdb.py
B146
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1526,6 +1526,17 @@ def do_integration_test(self, client_stdin):
stdout, stderr = attach_process.communicate(client_stdin, timeout=5)
process.wait()

client_stdout = process.stdout.read()
client_stderr = process.stderr.read(),

if process.returncode != 0:
print("server failed:")
print(stderr)

if attach_process.returncode != 0:
print("client failed:")
print(client_stderr)

self.assertEqual(process.returncode, 0)
self.assertEqual(attach_process.returncode, 0)

Expand All @@ -1535,8 +1546,8 @@ def do_integration_test(self, client_stdin):
"stderr": stderr,
},
"server": {
"stdout": process.stdout.read(),
"stderr": process.stderr.read(),
"stdout": client_stdout,
"stderr": client_stderr,
},
}

Expand Down
Loading
0