8000 gh-81793: Replace skip decorators with specific helpers by zware · Pull Request #133493 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-81793: Replace skip decorators with specific helpers #133493

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

gh-81793: Replace skip decorators with specific helpers #133493

merged 1 commit into from
May 6, 2025

Conversation

zware
Copy link
Member
@zware zware commented May 6, 2025 •
edited by bedevere-app bot
Loading

This should fix failure on the AMD64 Windows11 Non-Debug 3.x buildbot.

@zware zware requested a review from chris-eibl May 6, 2025 05:33
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label May 6, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 6, 2025
Closed
@zware zware added the skip news label May 6, 2025
chris-eibl
chris-eibl approved these changes May 6, 2025
View reviewed changes
Copy link
Member
@chris-eibl chris-eibl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested on Windows: as a regular user, the test is skipped, and in an admin shell the test is executed (and succeeds)

@zware zware enabled auto-merge (squash) May 6, 2025 05:37
@zware zware merged commit 5b07c6e into python:main May 6, 2025
44 checks passed
@zware zware deleted the fix_link_test branch May 6, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-eibl chris-eibl chris-eibl approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zware @chris-eibl
0