8000 gh-133447: Add basic color to `sqlite3` CLI by StanFromIreland · Pull Request #133461 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-133447: Add basic color to sqlite3 CLI #133461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 10, 2025
Merged

gh-133447: Add basic color to sqlite3 CLI #133461

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0a33388
Add
StanFromIreland May 5, 2025
e680c35
Import cleanup
StanFromIreland May 5, 2025
9bf179c
Merge branch 'main' into color_step1
StanFromIreland May 5, 2025
b456133
Highlight error messages
StanFromIreland May 5, 2025
8ef9217
Merge branch 'main' into color_step1
StanFromIreland May 6, 2025
ca015a1
Now with themes!
StanFromIreland May 6, 2025
2c06076
Simpler usage
StanFromIreland May 6, 2025
198399e
Fixup
StanFromIreland May 6, 2025
2a8c729
Simplify
ambv May 6, 2025
a220442
Don't skip coloring errors on single-statement execution
ambv May 6, 2025
e65d724
Also ignore color in the CLI test case
ambv May 6, 2025
66711a0
Clean up
StanFromIreland May 6, 2025
62a0164
Fix line removal
StanFromIreland May 7, 2025
52ee84c
Merge branch 'main' into color_step1
StanFromIreland May 9, 2025
4ed5815
Lint
StanFromIreland May 9, 2025
4c0b52c
fixup! Lint
StanFromIreland May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up
  • Loading branch information
@StanFromIreland
StanFromIreland committed May 6, 2025
commit 66711a04bae7295771806c2bea91b6c0a20624cc
3 changes: 1 addition & 2 deletions Lib/sqlite3/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ def execute(c, sql, suppress_errors=True, theme=theme_no_color):
except AttributeError:
pass
print(
f"{t.type}{tp}{t.reset}: {t.message}{e}{t.reset}",
file=sys.stderr,
f"{t.type}{tp}{t.reset}: {t.message}{e}{t.reset}", file=sys.stderr
)
if not suppress_errors:
sys.exit(1)
Expand Down
2 changes: 0 additions & 2 deletions Lib/test/test_sqlite3/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
captured_stdout,
captured_stderr,
captured_stdin,
force_not_colorized,
force_not_colorized_test_class,
)

Expand Down Expand Up @@ -39,7 +38,6 @@ def expect_failure(self, *args):
self.assertEqual(out, "")
return err

@force_not_colorized
def test_cli_help(self):
out = self.expect_success("-h")
self.assertIn("usage: ", out)
Expand Down
Loading
0