8000 GH-133261: Make sure that the GC doesn't untrack objects in trashcan by markshannon · Pull Request #133431 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-133261: Make sure that the GC doesn't untrack objects in trashcan #133431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 5, 2025
+36 −6
Merged

GH-133261: Make sure that the GC doesn't untrack objects in trashcan #133431

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
372eabc
Make sure that the GC doesn't untrack objects in trashcan
markshannon May 5, 2025
c18073c
Add news
markshannon May 5, 2025
ee95803
Make functions static
markshannon May 5, 2025
cb357f9
Helpers are needed for no-gil build
markshannon May 5, 2025
48a244d
Functions aren't needed for no-gil build
markshannon May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make functions static
  • Loading branch information
@markshannon
markshannon committed May 5, 2025
commit ee9580327ba9e845373184ab7ec6f5154e12169c
4 changes: 2 additions & 2 deletions Objects/object.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2934,8 +2934,8 @@
* an object. It is important that we never store 0 (NULL).
* It is also important to not make the object appear immortal,
* or it might be untracked by the cycle GC. */
uintptr_t
static uintptr_t
pointer_to_safe_refcount(void *ptr)

Check warning on line 2938 in Objects/object.c

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

‘pointer_to_safe_refcount’ defined but not used [-Wunused-function]

Check warning on line 2938 in Objects/object.c

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) 

‘pointer_to_safe_refcount’ defined but not used [-Wunused-function]
{
uintptr_t full = (uintptr_t)ptr;
assert((full & 3) == 0);
Expand All @@ -2950,8 +2950,8 @@
#endif
}

void *
static void *
safe_refcount_to_pointer(uintptr_t refcnt)

Check warning on line 2954 in Objects/object.c

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

‘safe_refcount_to_pointer’ defined but not used [-Wunused-function]

Check warning on line 2954 in Objects/object.c

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) 

‘safe_refcount_to_pointer’ defined but not used [-Wunused-function]
{
#if defined(Py_GIL_DISABLED)
return (void *)(refcnt - 1);
Expand Down
Loading
0