8000 gh-133371: Don't optimize `LOAD_FAST` instructions whose local is killed by `DELETE_FAST` by mpage · Pull Request #133383 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-133371: Don't optimize LOAD_FAST instructions whose local is killed by DELETE_FAST #133383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025
Merged

gh-133371: Don't optimize LOAD_FAST instructions whose local is killed by DELETE_FAST #133383

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b78eb39
Don't optimize `LOAD_FAST` instructions whose local is killed by `DEL…
mpage May 4, 2025
e1182c7
Bump the magic number
mpage May 5, 2025
193c16c
Add minimal repro of crash as a test
mpage May 5, 2025
09e834c
Merge branch 'main' into gh-133371-handle-del-fast
mpage May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bump the magic number
  • Loading branch information
@mpage
mpage committed May 5, 2025
commit e1182c74aa5f7aa4df2e2d144922bfd36f633455
3 changes: 2 additions & 1 deletion Include/internal/pycore_magic_number.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@ Known values:
Python 3.14a7 3621 (Optimize LOAD_FAST opcodes into LOAD_FAST_BORROW)
Python 3.14a7 3622 (Store annotations in different class dict keys)
Python 3.14a7 3623 (Add BUILD_INTERPOLATION & BUILD_TEMPLATE opcodes)
Python 3.14b1 3624 (Don't optimize LOAD_FAST when local is killed by DELETE_FAST)

Python 3.15 will start with 3650

Expand All @@ -288,7 +289,7 @@ PC/launcher.c must also be updated.

*/

#define PYC_MAGIC_NUMBER 3623
#define PYC_MAGIC_NUMBER 3624
/* This is equivalent to converting PYC_MAGIC_NUMBER to 2 bytes
(little-endian) and then appending b'\r\n'. */
#define PYC_MAGIC_NUMBER_TOKEN \
Expand Down
Loading
0