-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-133346: Make theming support in _colorize extensible #133347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
3344008
gh-133346: Make theming support in _colorize extensible
ambv 68e2385
Fix lint
ambv 252dfa0
Add theming to traceback.py
ambv b29c9b9
Fix WASI test failures
ambv ca34939
Apply suggestions from code review
ambv 5c5c3e1
Add theming to unittest
hugovk f449e7b
Add missing plumbing for _colorize.Unittest
ambv 8da314f
Adapt tests to theming when executed with -j
ambv 65d3a78
Fix. lint.
ambv 0866fd8
Add blurb and some docstrings
ambv 965c7cf
FIX. LINT.
ambv 230d658
Add theming to argparse
hugovk c4808c8
Apply suggestions from code review
ambv fd9c85c
Update test_argparse to use theme not color and fix bug
hugovk 664ef14
Merge branch 'main' into colorize-theme-support
ambv e67fda9
Rename REPL to Syntax now that pdb is using it, too; adapt pdb tests
ambv 70ca161
Bring json.tool into the theming fold
ambv 3166d63
Merge branch 'main' into colorize-theme-support
ambv 5c45ddb
Make no_colors() into classmethods
ambv 68a5c44
Address review
ambv 9f51769
Group effort
ambv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a little unfortunate for import times that this will bring a dependency on
dataclasses
module to all modules that import this. :-(