8000 gh-132876: workaround broken ldexp() on Windows 10 by skirpichev · Pull Request #133135 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-132876: workaround broken ldexp() on Windows 10 #133135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 26, 2025
Merged

gh-132876: workaround broken ldexp() on Windows 10 #133135

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
812276c
gh-132876: workaround broken ldexp() on Windows 10
skirpichev Apr 29, 2025
d331240
Update Modules/mathmodule.c
skirpichev Apr 29, 2025
1b90e9c
Apply suggestions from code review
skirpichev Apr 29, 2025
e1c2f99
Update Modules/mathmodule.c
skirpichev Apr 29, 2025
35bd457
Update Modules/mathmodule.c
skirpichev Apr 30, 2025
e105d76
Apply suggestions from code review
skirpichev Apr 30, 2025
514ecc0
Apply suggestions from code review
skirpichev Apr 30, 2025
ccc262c
Apply suggestions from code review//lint
skirpichev Apr 30, 2025
5da5752
Merge branch 'master' into fix-ldexp-MS/132876
skirpichev May 26, 2025
bd5446f
address review: added regression test
skirpichev May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Modules/mathmodule.c
  • Loading branch information
@skirpichev
skirpichev authored Apr 29, 2025
commit d3312402db16ded2a49b45b72baa74759739699b
5 changes: 3 additions & 2 deletions Modules/mathmodule.c
C86C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2172,8 +2172,9 @@
frexp(x, &original_exp);
if (original_exp > DBL_MIN_EXP) {
/* Shift down to the smallest normal binade. No bits lost. */
x = ldexp(x, DBL_MIN_EXP - original_exp);
exp += original_exp - DBL_MIN_EXP;
int shift = DBL_MIN_EXP - original_exp
x = ldexp(x, shift);

Check failure on line 2176 in Modules/mathmodule.c

View workflow job for this annotation

GitHub Actions / Windows / Build and test (arm64) 

syntax error: missing ';' before identifier 'x' [C:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

Check failure on line 2176 in Modules/mathmodule.c

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (arm64) 

syntax error: missing ';' before identifier 'x' [C:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

Check failure on line 2176 in Modules/mathmodule.c

View workflow job for this annotation

GitHub Actions / Windows / Build and test (x64) 

syntax error: missing ';' before identifier 'x' [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

Check failure on line 2176 in Modules/mathmodule.c

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (x64) 

syntax error: missing ';' before identifier 'x' [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
exp -= shift;
}
/* Multiplying by 2**exp finishes the job, and the HW will round as
appropriate. Note: if exp < -DBL_MANT_DIG, all of x is shifted
Expand Down
Loading
0