8000 gh-133036: Deprecate codecs.open by methane · Pull Request #133038 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-133036: Deprecate codecs.open #133038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 30, 2025
Merged

gh-133036: Deprecate codecs.open #133038

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
655759b
gh-133036: deprecate codecs.open
methane Apr 27, 2025
47ebf4f
codecs_open_nowarn -> codecs_open_no_warn
methane Apr 28, 2025
ff0d25d
fix tests
methane Apr 28, 2025
cba4e03
remove codecs.open from error message
methane Apr 28, 2025
c2a52e3
fix windows test
methane Apr 28, 2025
744eff0
add pending-removal-in-future entry
methane Apr 29, 2025
b2dced5
Apply suggestions from code review
methane Apr 29, 2025
c8af536
Update Doc/deprecations/pending-removal-in-future.rst
methane Apr 29, 2025
ce5c94b
Update Lib/test/test_codecs.py
methane Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix windows test
  • Loading branch information
@methane
methane committed Apr 28, 2025
commit c2a52e390f092ca051a465ce87aaaccf961c0b8e
4 changes: 2 additions & 2 deletions Lib/test/test_codecs.py
View file 8000
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ def check(input, expect):

# On small versions of Windows like Windows IoT or Windows Nano Server not all codepages are present
def is_code_page_present(cp):
from ctypes import POINTER, WINFUNCTYPE, WinDLL
from ctypes import POINTER, WINFUNCTYPE, WinDLL, Structure
from ctypes.wintypes import BOOL, BYTE, WCHAR, UINT, DWORD

MAX_LEADBYTES = 12 # 5 ranges, 2 bytes ea., 0 term.
MAX_DEFAULTCHAR = 2 # single or double byte
MAX_PATH = 260
class CPINFOEXW(ctypes.Structure):
class CPINFOEXW(Structure):
_fields_ = [("MaxCharSize", UINT),
("DefaultChar", BYTE*MAX_DEFAULTCHAR),
("LeadByte", BYTE*MAX_LEADBYTES),
Expand Down
Loading
0