gh-91221: remove unreliable checks on curses.pair_content(0)
#132986
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current terminal fg/bg colors given by `pair_content(0)`, which is backed by `extended_pair_content(3)`, depends on the terminal emulator and its supported colors. Thus, its output cannot not be reliably checked.
curses.pair_content(0)curses.pair_content(0)
|
I'll use #132990. At least we won't bother people. If there are more users that can be annoyed, let's just remove the check later. |
Comment on lines
+989
to
+992
| # The current terminal fg/bg colors given by pair_content(0), | ||
| # which is backed by extended_pair_content(3), depends on the | ||
| # terminal emulator and its supported colors. | ||
| curses.pair_content(0) |
There was a problem hiding this comment.
If we remove the check, the call to curses.pair_content(0) can be removed as well. It is no longer useful.
There was a problem hiding this comment.
I eventually decided to use the other PR. It's not really an issue and it could catch issues when we call pair_content(0) from the C code.
| @@ -0,0 +1,3 @@ | |||
| Do not check the output of :func:`curses.pair_content(0) | |||
There was a problem hiding this comment.
We usually do not add NEWS entries for test-only changes. They are not useful for Python users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current terminal fg/bg colors given by
pair_content(0), which is backed byextended_pair_content(3), depends on the terminal emulator and its supported colors. Thus, its output cannot not be reliably checked.