8000 gh-122781: Fix `%z` in `strptime` by StanFromIreland · Pull Request #132922 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-122781: Fix %z in strptime #132922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2025
Merged

gh-122781: Fix %z in strptime #132922

merged 2 commits into from
May 20, 2025

Conversation

StanFromIreland
Copy link
Contributor
@StanFromIreland StanFromIreland commented Apr 25, 2025 •
edited
Loading

Alternate (simpler) approach than old pr: #122829 by just updating the regex (and testing it this time).

@bedevere-app bedevere-app bot mentioned this pull request Apr 25, 2025
Closed
@StanFromIreland StanFromIreland mentioned this pull request Apr 25, 2025
Open
@StanFromIreland
Copy link
Contributor Author

Test fails are unrelated.

pganssle
pganssle requested changes May 20, 2025
View reviewed changes
Copy link
Member
@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good approach, just a nit about how to do the tests and also want to make sure %:z is covered as well.

@bedevere-app
Copy link
bedevere-app bot commented May 20, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@StanFromIreland
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-app
Copy link
bedevere-app bot commented May 20, 2025

Thanks for making the requested changes!

@pganssle: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from pganssle May 20, 2025 15:53
@pganssle pganssle enabled auto-merge (squash) May 20, 2025 16:19
@pganssle pganssle merged commit 99b5808 into python:main May 20, 2025
44 of 47 checks passed
@StanFromIreland StanFromIreland deleted the strptime-fix-z branch May 20, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pganssle pganssle pganssle approved these changes

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanFromIreland @pganssle
0