8000 gh-132710: only use stable `_uuid.generate_time_safe()` to deduce MAC address by picnixz · Pull Request #132901 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-132710: only use stable _uuid.generate_time_safe() to deduce MAC address #132901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 26, 2025
+357 −28
Merged

gh-132710: only use stable _uuid.generate_time_safe() to deduce MAC address #132901

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ee71d62
only use stable `_uuid.generate_time_safe()` to deduce MAC address
picnixz Apr 22, 2025
16200ae
Merge branch 'main' into fix/uuid/mac-address-libuuid-132710
picnixz Apr 25, 2025
8da7081
Merge branch 'main' into fix/uuid/mac-address-libuuid-132710
picnixz Apr 26, 2025
6083e97
[empty commit]
picnixz Apr 26, 2025
7a77509
add tests
picnixz May 6, 2025
e311181
Merge remote-tracking branch 'upstream/main' into fix/uuid/mac-addres…
picnixz May 9, 2025
19c6262
Merge branch 'main' into fix/uuid/mac-address-libuuid-132710
picnixz May 17, 2025
03bcfad
Merge branch 'main' into fix/uuid/mac-address-libuuid-132710
picnixz May 19, 2025
fd84b3c
Merge branch 'main' into fix/uuid/mac-address-libuuid-132710
picnixz May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add tests
  • Loading branch information
@picnixz
picnixz committed May 6, 2025
commit 7a77509b18fd560192e628aca77eca30a82c0ffe
28 changes: 28 additions & 0 deletions Lib/test/test_uuid.py
View file 8000
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

from test import support
from test.support import import_helper
from test.support.script_helper import assert_python_ok

py_uuid = import_helper.import_fresh_module('uuid', blocked=['_uuid'])
c_uuid = import_helper.import_fresh_module('uuid', fresh=['_uuid'])
Expand Down Expand Up @@ -1217,10 +1218,37 @@ def test_cli_uuid5_ouputted_with_valid_namespace_and_name(self):
class TestUUIDWithoutExtModule(BaseTestUUID, unittest.TestCase):
uuid = py_uuid


@unittest.skipUnless(c_uuid, 'requires the C _uuid module')
class TestUUIDWithExtModule(BaseTestUUID, unittest.TestCase):
uuid = c_uuid

def check_has_stable_libuuid_extractable_node(self):
if not self.uuid._has_stable_extractable_node:
self.skipTest("libuuid cannot deduce MAC address")

@unittest.skipUnless(os.name == 'posix', 'POSIX only')
def test_unix_getnode_from_libuuid(self):
self.check_has_stable_libuuid_extractable_node()
script = 'import uuid; print(uuid._unix_getnode())'
_, n_a, _ = assert_python_ok('-c', script)
_, n_b, _ = assert_python_ok('-c', script)
n_a, n_b = n_a.decode().strip(), n_b.decode().strip()
self.assertTrue(n_a.isdigit())
self.assertTrue(n_b.isdigit())
self.assertEqual(n_a, n_b)

@unittest.skipUnless(os.name == 'nt', 'Windows only')
def test_windows_getnode_from_libuuid(self):
self.check_has_stable_libuuid_extractable_node()
script = 'import uuid; print(uuid._windll_getnode())'
_, n_a, _ = assert_python_ok('-c', script)
_, n_b, _ = assert_python_ok('-c', script)
n_a, n_b = n_a.decode().strip(), n_b.decode().strip()
self.assertTrue(n_a.isdigit())
self.assertTrue(n_b.isdigit())
self.assertEqual(n_a, n_b)


class BaseTestInternals:
_uuid = py_uuid
Expand Down
Loading
0