8000 gh-131531: android.py enhancements to support cibuildwheel by mhsmith · Pull Request #132870 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-131531: android.py enhancements to support cibuildwheel #132870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 5, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert use of NODIST environment variables
  • Loading branch information
mhsmith committed May 29, 2025
commit f36273a2cf393339338a319f54553ab1f5871835
13 changes: 1 addition & 12 deletions Android/android.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,22 +78,11 @@ def subdir(*parts, create=False):

def run(command, *, host=None, env=None, log=True, **kwargs):
kwargs.setdefault("check", True)

if env is None:
env = os.environ.copy()

if host:
# The -I and -L arguments used when building Python should not be reused
# when building third-party extension modules, so pass them via the
# NODIST environment variables.
host_env = android_env(host)
for name in ["CFLAGS", "CXXFLAGS", "LDFLAGS"]:
flags = []
nodist = []
for word in host_env[name].split():
(nodist if word.startswith(("-I", "-L")) else flags).append(word)
host_env[name] = " ".join(flags)
host_env[f"{name}_NODIST"] = " ".join(nodist)

print_env(host_env)
env.update(host_env)

Expand Down
Loading
0