8000 gh-132413: Fix crash in _datetime when used at shutdown by neonene · Pull Request #132599 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-132413: Fix crash in _datetime when used at shutdown #132599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

gh-132413: Fix crash in _datetime when used at shutdown #132599

wants to merge 41 commits into from

Conversation

neonene
Copy link
Contributor
@neonene neonene commented Apr 16, 2025 •
edited
Loading

This converts the IsoCalendarDate heap type back to the static type used in 3.12,
so that the _datetime will not heavily depend on its module state.

Unlike #132665, this does not extend the interpreter state.

@bedevere-app bedevere-app bot mentioned this pull request Apr 16, 2025
Open
@neonene neonene changed the title gh-132413: datetime: Fix crash when used during interpreter shutdown gh-132413: datetime: Fix crash when used during interp shutdown Apr 16, 2025
@neonene neonene marked this pull request as ready for review April 16, 2025 14:48
@neonene
Copy link
Contributor Author
neonene commented Apr 16, 2025

cc @Jacoblightning @ericsnowcurrently

@neonene neonene marked this pull request as draft April 17, 2025 21:03
@neonene

This comment was marked as outdated.

Sign in to view
@neonene neonene closed this Apr 18, 2025
@neonene neonene reopened this Apr 20, 2025
@neonene neonene changed the title gh-132413: datetime: Fix crash when used during interp shutdown gh-132413: Fix crash in _datetime when used at shutdown (alt) Apr 20, 2025
@neonene neonene marked this pull request as ready for review April 20, 2025 23:07
@neonene neonene mentioned this pull request Apr 20, 2025
Draft
neonene
neonene commented Apr 27, 2025
View reviewed changes
@neonene neonene closed this Apr 27, 2025
@neonene neonene reopened this Apr 30, 2025
@neonene neonene closed this Apr 30, 2025
@neonene neonene reopened this May 7, 2025
@neonene neonene changed the title gh-132413: Fix crash in _datetime when used at shutdown (alt) gh-132413: Fix crash in _datetime when used at shutdown May 7, 2025
neonene
neonene commented May 8, 2025
View reviewed changes
@neonene
Copy link
Contributor Author
neonene commented May 8, 2025 •
edited
Loading

Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@neonene
0