-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
GH-132554: "Virtual" iterators #132555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
GH-132554: "Virtual" iterators #132555
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
7476442
FOR_ITER now pushes NULL as well as the iterator. Preparation for vir…
markshannon 38a429f
use tagged ints for indexes. Work in progress
markshannon 2caf56f
Remove debug code
markshannon 588943a
Regenerate files
markshannon aa62e39
Tidy up list of non-escaping functions
markshannon 88562ec
Fix up list iteration for FT build
markshannon 025049d
Fix tier 2 FT build
markshannon 35e389d
Remove debugging code
markshannon e8f4ce6
Merge branch 'main' into virtual-iterators
markshannon ed89950
Rename function
markshannon ec8d797
Restrict specialization in free-threaded build
markshannon cad1946
Merge branch 'main' into virtual-iterators
markshannon 428735b
Add news
markshannon 4c83848
handle tagged ints when doing type checks
markshannon f43ccc3
Fix long check
markshannon 3fd46c3
Attempt to make _PyForIter_NextWithIndex thread safe.
markshannon 433282f
Add review comment
markshannon e915a05
Simplify list indexing code
markshannon 69a328d
Merge branch 'main' into virtual-iterators
markshannon 6d1b93e
GET_ITER may leave the iterable on the stack
markshannon 37ca285
Fix test_dis
markshannon f3b9074
Merge branch 'main' into virtual-iterators
markshannon 0efab59
Merge branch 'main' into virtual-iterators
markshannon a0d814b
Merge branch 'main' into virtual-iterators
markshannon 5cd55c4
Merge branch 'main' into virtual-iterators
markshannon 867bd10
Merge branch 'main' into virtual-iterators
markshannon d9dc597
Clarify assert
markshannon d60ef23
Checked for tagged ints
markshannon 9a9d20d
Address review comments
markshannon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
GET_ITER may leave the iterable on the stack
- Loading branch information
commit 6d1b93e760b1312c2b938f89c87066be6195b303
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add this to make sure the test is testing what the comment is saying.
assert(sys.getrefcount(x) == 1)