-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-131591: Allow pdb to attach to a running process #132451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
5225333
Allow pdb to attach to a running process
godlygeek 78a3085
Remove 2 unused _RemotePdb instance attributes
godlygeek 90e0a81
Reduce duplication for 'debug' command
godlygeek e44a670
End commands entry on 'end' and ^C and ^D
godlygeek e837246
Set the frame for remote pdb to stop in explicitly
godlygeek 27efa97
Fix an unbound local in an error message
godlygeek 557a725
Clean up remote PDB detaching
godlygeek 7f7584a
Allow ctrl-c to interrupt a running process
godlygeek 5666ffb
Automatically detach if the client dies unexpectedly
godlygeek 325f166
Clear _last_pdb_instance on detach
godlygeek 72830e2
Refuse to attach if another PDB instance is installed
godlygeek 27c6780
Handle the confirmation prompt issued by 'clear'
godlygeek baaf28a
Make message and error handle non-string args
godlygeek e61cc31
Add some basic tests
pablogsal 5d59ce1
Don't use deprecated method
pablogsal 09adb2b
Try to prevent a PermissionError on Windows
godlygeek 600aa05
Address review comments
godlygeek 0601f10
Add protocol versioning and support -c commands
godlygeek 5a1755b
Fix tests to match new _connect signature for protocol versioning/com…
godlygeek f184e4e
Add some comments describing our protocol
godlygeek 82b71f8
Use the 'commands' state for '(com)' prompts
godlygeek 3986c17
Remove choices parameter from _prompt_for_confirmation
8000
godlygeek 2e69667
Rename _RemotePdb to _PdbServer
godlygeek 55adbcc
Avoid fallthrough in signal handling
godlygeek 0bda5c2
Fix handling of a SystemExit raised in normal pdb mode
godlygeek 5e93247
Address nit
godlygeek f799e83
Use textwrap.dedent for test readability
godlygeek 46fb219
Drop dataclasses dependency
godlygeek 1ec9475
Combine the two blocks for handling -p PID into one
godlygeek 662c7eb
Add a news entry
godlygeek ac36d7d
Skip remote PDB integration test on WASI
godlygeek f06d9c2
Two small things missed in the previous fixes
godlygeek 715af27
Remove call to set_step in interrupt handler
godlygeek c654fdf
More tests
pablogsal 205bc55
More tests
pablogsal bbe784b
More tests
pablogsal 30cb537
Add what's new entry
pablogsal 659556f
use dedent
pablogsal 6c2d970
Add synchronization to test_keyboard_interrupt
godlygeek 100be44
Stop sending a "signal" message in test_keyboard_interrupt"
godlygeek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
More tests
- Loading branch information
commit 205bc552b68f145a26e0263b38051a399afdba59
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you do
textwrap.dedent()
for all the scripts? So it's visually indented properly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaogaotiantian done