GH-132417: ctypes: Fix potential Py_DECREF(NULL) in py_object handling #132418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
NicolasT
added a commit
to NicolasT/cpython
that referenced
this pull request
Apr 11, 2025
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
You don't need to force-push, because all commits will be squashed on merge. |
tomasr8
reviewed
Apr 11, 2025
Misc/NEWS.d/next/Library/2025-04-11-21-48-49.gh-issue-132417.uILGdS.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
skirpichev
approved these changes
Apr 11, 2025
picnixz
approved these changes
Apr 12, 2025
Misc/NEWS.d/next/Library/2025-04-11-21-48-49.gh-issue-132417.uILGdS.rst
Outdated
Show resolved
Hide resolved
|
I'll let you apply / reject the suggestions and will merge this by the end of the week. Thanks for the fix! |
kumaraditya303
approved these changes
Apr 12, 2025
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 12, 2025
…g functions returning `PyObject *` (pythonGH-132418) Some functions (such as `PyErr_Occurred`) with a `restype` set to `ctypes.py_object` may return NULL without setting an exception. (cherry picked from commit 2aab2db) Co-authored-by: Nicolas Trangez <ikke@nicolast.be>
|
GH-132425 is a backport of this pull request to the 3.13 branch. |
picnixz
pushed a commit
that referenced
this pull request
Apr 12, 2025
…ng functions returning `PyObject *` (GH-132418) (#132425) GH-132417: ctypes: Fix potential `Py_DECREF(NULL)` when handling functions returning `PyObject *` (GH-132418) Some functions (such as `PyErr_Occurred`) with a `restype` set to `ctypes.py_object` may return NULL without setting an exception. (cherry picked from commit 2aab2db) Co-authored-by: Nicolas Trangez <ikke@nicolast.be>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.