Address review

python · sobolevn · May 2, 2025 · Apr 11, 2025 · Apr 11, 2025 · Apr 11, 2025
commit 06a97b70fdf70596958ba33dba085a9a349de913
diff --git a/Lib/test/test_traceback.py b/Lib/test/test_traceback.py
@@ -4509,7 +4509,7 @@ def test_unbound_local_error_with_side_effect(self):
         class A:
             def __getattr__(self, key):
                 if key == 'foo':
-                    raise SystemExit('foo')
+                    raise AttributeError('foo')
                 if key == 'spam':
                     raise ValueError('spam')
 

diff --git a/Lib/traceback.py b/Lib/traceback.py
@@ -1534,7 +1534,7 @@ def _compute_suggestion_error(exc_value, tb, wrong_name):
             self = frame.f_locals['self']
             try:
                 has_wrong_name = hasattr(self, wrong_name)
-            except BaseException:
+            except Exception:
                 has_wrong_name = False
             if has_wrong_name:
                 return f"self.{wrong_name}"