Fix last comments

python · picnixz · Apr 19, 2025 · Apr 9, 2025 · Apr 10, 2025 · Apr 10, 2025
commit d78095a7fbbb768a8842188ab1a6aa47f8af0bf8
diff --git a/Lib/test/test_traceback.py b/Lib/test/test_traceback.py
@@ -3416,26 +3416,16 @@ def __repr__(self) -> str:
 
 # Used in test_dont_swallow_cause_or_context_of_falsey_exception and
 # test_dont_swallow_subexceptions_of_falsey_exceptiongroup.
-class FalseyBoolException(Exception):
+class FalseyException(Exception):
     def __bool__(self):
         return False
 
 
-class FalseyLenException(Exception):
-    def __len__(self):
-        return 0
-
-
-class FalseyBoolExceptionGroup(ExceptionGroup):
+class FalseyExceptionGroup(ExceptionGroup):
     def __bool__(self):
         return False
 
 
-class FalseyLenExceptionGroup(ExceptionGroup):
-    def __len__(self):
-        return 0
-
-
 class TestTracebackException(unittest.TestCase):
     def do_test_smoke(self, exc, expected_type_str):
         try:
@@ -3784,23 +3774,21 @@ def f():
 
     def test_dont_swallow_cause_or_context_of_falsey_exception(self):
         # see gh-132308: Ensure that __cause__ or __context__ attributes of exceptions
-        # that evaluate as falsey are included in the output.
-        # Recall: `x` is falsey if `len(x)` returns 0 or `bool(x)` returns False.
+        # that evaluate as falsey are included in the output. For falsey term,
+        # see https://docs.python.org/3/library/stdtypes.html#truth-value-testing.
 
-        for exc in (FalseyBoolException, FalseyLenException):
-            try:
-                raise exc from KeyError
-            except exc as e:
-                self.assertIn(cause_message, traceback.format_exception(e))
+        try:
+            raise FalseyException from KeyError
+        except FalseyException as e:
+            self.assertIn(cause_message, traceback.format_exception(e))
 
-        for exc in (FalseyBoolException, FalseyLenException):
+        try:
             try:
-                try:
-                    1/0
-                except ZeroDivisionError:
-                    raise exc
-            except exc as e:
-                self.assertIn(context_message, traceback.format_exception(e))
+                1/0
+            except ZeroDivisionError:
+                raise FalseyException
+        except FalseyException as e:
+            self.assertIn(context_message, traceback.format_exception(e))
 
 
 class TestTracebackException_ExceptionGroups(unittest.TestCase):
@@ -4005,24 +3993,23 @@ def test_comparison(self):
 
     def test_dont_swallow_subexceptions_of_falsey_exceptiongroup(self):
         # see gh-132308: Ensure that subexceptions of exception groups
-        # that evaluate as falsey are displayed in the output.
-        # Recall: `x` is falsey if `len(x)` returns 0 or `bool(x)` returns False.
+        # that evaluate as falsey are displayed in the output. For falsey term,
+        # see https://docs.python.org/3/library/stdtypes.html#truth-value-testing.
 
-        for falsey_exception in (FalseyBoolExceptionGroup, FalseyLenExceptionGroup):
-            try:
-                raise falsey_exception("Gih", (KeyError(), NameError()))
-            except Exception as ee:
-                str_exc = ''.join(traceback.format_exception(ee))
-                self.assertIn('+---------------- 1 ----------------', str_exc)
-                self.assertIn('+---------------- 2 ----------------', str_exc)
-
-            # Test with a falsey exception, in last position, as sub-exceptions.
-            msg = 'bool'
-            try:
-                raise falsey_exception("Gah", (KeyError(), FalseyBoolException(msg)))
-            except Exception as ee:
-                str_exc = traceback.format_exception(ee)
-                self.assertIn(f'{FalseyBoolException.__name__}: {msg}', str_exc[-2])
+        try:
+            raise FalseyExceptionGroup("Gih", (KeyError(), NameError()))
+        except Exception as ee:
+            str_exc = ''.join(traceback.format_exception(ee))
+            self.assertIn('+---------------- 1 ----------------', str_exc)
+            self.assertIn('+---------------- 2 ----------------', str_exc)
+
+        # Test with a falsey exception, in last position, as sub-exceptions.
+        msg = 'bool'
+        try:
+            raise FalseyExceptionGroup("Gah", (KeyError(), FalseyException(msg)))
+        except Exception as ee:
+            str_exc = traceback.format_exception(ee)
+            self.assertIn(f'{FalseyException.__name__}: {msg}', str_exc[-2])
 
 
 global_for_suggestions = None

diff --git a/Misc/NEWS.d/next/Library/2025-04-10-13-06-42.gh-issue-132308.1js5SI.rst b/Misc/NEWS.d/next/Library/2025-04-10-13-06-42.gh-issue-132308.1js5SI.rst
@@ -1,2 +1,3 @@
 The :class:`traceback.TracebackException` must include the  ``__context__``, ``__cause__`` attributes
 from falsey Exception, and the ``exceptions`` attribute from falsey ``ExceptionGroup`` in its render.
+For *falsey* term, see https://docs.python.org/3/library/stdtypes.html#truth-value-testing.